-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
Add LLaVA support #775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Add LLaVA support #775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Is it working with LLaVA1.5? |
30 tasks
Member
|
@LinkerCodeMonkey do you still plan to work on this PR? |
Collaborator
|
Closed as we added support for LLaVA in #3042 |
jikunshang
pushed a commit
to jikunshang/vllm
that referenced
this pull request
Feb 7, 2025
jikunshang
pushed a commit
to jikunshang/vllm
that referenced
this pull request
Feb 20, 2025
Support mla (vllm-project#775) [Deepseek r1] improve latenct cache by save last 64 in key cache and 512 in value cache (vllm-project#804) Before, we can only allocate 1854 blocks with 29.2G, now we are able to allocate 3156 blocks Performance wise, not visible regression and able to push to higher batch_size or longer context length --------- Signed-off-by: Chendi Xue <[email protected]>
jikunshang
pushed a commit
to jikunshang/vllm
that referenced
this pull request
Mar 14, 2025
Support mla (vllm-project#775) [Deepseek r1] improve latenct cache by save last 64 in key cache and 512 in value cache (vllm-project#804) Before, we can only allocate 1854 blocks with 29.2G, now we are able to allocate 3156 blocks Performance wise, not visible regression and able to push to higher batch_size or longer context length --------- Signed-off-by: Chendi Xue <[email protected]>
amy-why-3459
pushed a commit
to amy-why-3459/vllm
that referenced
this pull request
Sep 15, 2025
### What this PR does / why we need it? This is a continuing work of vllm-project#716. This PR add workflow to build and release wheel, and also release source to PYPI. We have 3 conditions to trigger the workflow: 1. PR to `main` and `*-dev` 2. push to `main` and `*-dev` 3. push tag with name of `v*` Release to PYPI will only be done under condition 3. Under condition 1 and 2, it will generate .tar.gz and build .whl, upload to github artifacts but will not release. update: Will build .whl and upload to github artifacts with scheduled task. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? All triggered conditions are well tested with my fork repo. --------- Signed-off-by: Shuqiao Li <[email protected]> Signed-off-by: Yikun Jiang <[email protected]> Co-authored-by: Yikun Jiang <[email protected]>
zhyajie
pushed a commit
to zhyajie/vllm
that referenced
this pull request
Oct 30, 2025
update dsr1 launch script & add benchmark script
wz1qqx
pushed a commit
to wz1qqx/vllm
that referenced
this pull request
Dec 29, 2025
* Fix linux builds with cibuildwheel Build is broken because torch 2.7 is not supported by CUDA 12.4 and torch 2.7 does not have distributions for manylinux_2_17_x86_64. This commit updates the manylinux cuda image used by cibuilder to manylinux_2_28_x86_64 which is supported by torch 2.7 Signed-off-by: Martin Hickey <[email protected]> * Remove cibuild configuration duplication Configuration for cibuilder was set in pyproject.toml and also as env variables in GitHub publish workflow. This commit removes the configuration in workflow and centralizes it in pyproject.toml. Signed-off-by: Martin Hickey <[email protected]> * Clean more disk space from runner Running out of space when building cp312-manylinux_x86_64 wheel. This step is to remove more space. Signed-off-by: Martin Hickey <[email protected]> * Refactor runner disk cleanup Signed-off-by: Martin Hickey <[email protected]> --------- Signed-off-by: Martin Hickey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added code to support llava. #307
test code: