[Kernel] register punica functions as torch ops #7591
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge). To run full CI, you can do one of these:
🚀 |
bnellnm
changed the title
vllm/lora/ops/bgmv_expand.py
Outdated
| @@ -108,6 +107,7 @@ def bgmv_expand( | |||
| override_config (Optional[Dict[str, int]], optional): Defaults to None. | |||
| Triton grid config | |||
| """ | |||
| override_config: Optional[Dict[str, int]] = None | |||
There was a problem hiding this comment.
cc @jeejeelee what's the purpose of this code?
There was a problem hiding this comment.
This is the configuration passed when tuning kernel. We currently don't support tuning kernel for punica, if tuning is implemented later, we can consider adding this parameter then.
There's already tests for these in tests/lora/test_punica_sizes.py and test_punica_variation.py |
|
/ready |
github-actions
bot
added
the
ready
| @@ -180,3 +171,8 @@ def bgmv_expand_slice( | |||
| **config, | |||
| ) | |||
| return | |||
|
|
|||
|
|
|||
| bgmv_expand_slice = torch.library.custom_op("lora::bgmv_expand_slice", | |||
There was a problem hiding this comment.
custom_op is torch 2.4+
Probably worth adding something similar to https://github.com/vllm-project/vllm/pull/7886/files#diff-dab7693bd00a09e22d39aee684a7e419aa358a47c4bd20df33d44f5adf60d304R1114-R1115 in punica.py:16 around the import
Signed-off-by: Alvant <[email protected]>
Register punica functions as torch ops to support dynamo and prevent graph breaks.
Broken off from #6917
cc @youkaichao, @SageMoore
PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]for bug fixes.[CI/Build]for build or continuous integration improvements.[Doc]for documentation fixes and improvements.[Model]for adding a new model or improving an existing model. Model name should appear in the title.[Frontend]For changes on the vLLM frontend (e.g., OpenAI API server,LLMclass, etc.)[Kernel]for changes affecting CUDA kernels or other compute kernels.[Core]for changes in the core vLLM logic (e.g.,LLMEngine,AsyncLLMEngine,Scheduler, etc.)[Hardware][Vendor]for hardware-specific changes. Vendor name should appear in the prefix (e.g.,[Hardware][AMD]).[Misc]for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
format.shto format your code.docs/source/if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with
rfc-requiredand might not go through the PR.What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
action-requiredlabel on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!