Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Fix reinit procedure in ModelInputForGPUBuilder #7360

Merged
merged 1 commit into from
Aug 9, 2024
Merged

[Bugfix] Fix reinit procedure in ModelInputForGPUBuilder #7360

merged 1 commit into from
Aug 9, 2024

Conversation

alexm-neuralmagic
Copy link
Collaborator

This fixes the issues with entrypoints tests that were found by @DarkLight1337

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@alexm-neuralmagic
Copy link
Collaborator Author

/ready

@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 9, 2024
@alexm-neuralmagic
Copy link
Collaborator Author

alexm-neuralmagic commented Aug 9, 2024 •
edited
Loading

@DarkLight1337 @youkaichao @comaniac @njhill

DarkLight1337
DarkLight1337 approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) August 9, 2024 14:26
@DarkLight1337 DarkLight1337 merged commit 74af2bb into vllm-project:main Aug 9, 2024
60 checks passed
sfc-gh-mkeralapura pushed a commit to sfc-gh-mkeralapura/vllm that referenced this pull request Aug 12, 2024
@alexm-neuralmagic @sfc-gh-mkeralapura
[Bugfix] Fix reinit procedure in ModelInputForGPUBuilder (vllm-projec…
c3cb225 
…t#7360)
kylesayrs pushed a commit to neuralmagic/vllm that referenced this pull request Aug 17, 2024
@alexm-neuralmagic @kylesayrs
[Bugfix] Fix reinit procedure in ModelInputForGPUBuilder (vllm-projec…
9c60117 
…t#7360)
fialhocoelho pushed a commit to opendatahub-io/vllm that referenced this pull request Aug 22, 2024
@alexm-neuralmagic @fialhocoelho
[Bugfix] Fix reinit procedure in ModelInputForGPUBuilder (vllm-projec…
cb6db23 
…t#7360)
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
@alexm-neuralmagic @Alvant
[Bugfix] Fix reinit procedure in ModelInputForGPUBuilder (vllm-projec…
169f21e 
…t#7360)

Signed-off-by: Alvant <[email protected]>
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
@alexm-neuralmagic
[Bugfix] Fix reinit procedure in ModelInputForGPUBuilder (vllm-projec…
d18ff0f 
…t#7360)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexm-neuralmagic @DarkLight1337