[FrontEnd] Make merge_async_iterators is_cancelled arg optional
#7282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vllm-project#7111 made a change to the merge_async_iterators utils function to add an is_cancelled arg. It would be good for this new arg to be optional to retain backwards compatibility for other server front-ends that might already be using this utility function.
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge). To run full CI, you can do one of these:
🚀 |
simon-mo
approved these changes
Aug 7, 2024
dtrifiro
added a commit
to opendatahub-io/vllm-tgis-adapter
that referenced
this pull request
Aug 8, 2024
This reverts commit 09290e6. The mandatory `is_cancelled` kwarg was made optional in vllm-project/vllm#7282
github-merge-queue bot
pushed a commit
to opendatahub-io/vllm-tgis-adapter
that referenced
this pull request
Aug 12, 2024
This reverts commit 09290e6. The mandatory `is_cancelled` kwarg was made optional in vllm-project/vllm#7282
sfc-gh-mkeralapura
pushed a commit
to sfc-gh-mkeralapura/vllm
that referenced
this pull request
Aug 12, 2024
kylesayrs
pushed a commit
to neuralmagic/vllm
that referenced
this pull request
Aug 17, 2024
fialhocoelho
pushed a commit
to opendatahub-io/vllm
that referenced
this pull request
Aug 22, 2024
Alvant
pushed a commit
to compressa-ai/vllm
that referenced
this pull request
Oct 26, 2024
…llm-project#7282) Signed-off-by: Alvant <[email protected]>
KuntaiDu
pushed a commit
to KuntaiDu/vllm
that referenced
this pull request
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7111 made a change to the merge_async_iterators utils function to add an is_cancelled arg. It would be good for this new arg to be optional to retain backwards compatibility for other server front-ends that might already be using this utility function.