Skip to content

[Bugfix][FP8] Fix dynamic FP8 Marlin quantization #7219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 7, 2024

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Aug 6, 2024

FIX #7216

We simply weren't expanding the per-tensor scales to channelwise for the fp16->fp8 dynamic quant case, which is needed for FP8 Marlin.

Also adds VLLM_TEST_FORCE_FP8_MARLIN environment variable so we can force testing of FP8 Marlin on GPUs with hardware support for FP8

Copy link

github-actions bot commented Aug 6, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 6, 2024
@mgoin mgoin requested a review from youkaichao August 6, 2024 23:51
@mgoin
Copy link
Member Author

mgoin commented Aug 6, 2024

Hi @youkaichao I'm not sure the state of the build right now, but the failing tests seem to be unrelated. Lmk if you think I should investigate further

@youkaichao
Copy link
Member

yes test failures are unrelated. I will hand it over to @robertgshaw2-neuralmagic for review on the quantization side.

@youkaichao youkaichao merged commit 5223199 into main Aug 7, 2024
50 of 52 checks passed
@youkaichao youkaichao deleted the fix-dynamic-fp8-marlin branch August 7, 2024 18:23
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Dynamic FP8 Marlin quantization fails on 0.5.4
3 participants