-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
[Bugfix][FP8] Fix dynamic FP8 Marlin quantization #7219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge). To run full CI, you can do one of these:
🚀 |
Hi @youkaichao I'm not sure the state of the build right now, but the failing tests seem to be unrelated. Lmk if you think I should investigate further |
yes test failures are unrelated. I will hand it over to @robertgshaw2-neuralmagic for review on the quantization side. |
Signed-off-by: Alvant <[email protected]>
Signed-off-by: LeiWang1999 <[email protected]>
FIX #7216
We simply weren't expanding the per-tensor scales to channelwise for the fp16->fp8 dynamic quant case, which is needed for FP8 Marlin.
Also adds
VLLM_TEST_FORCE_FP8_MARLIN
environment variable so we can force testing of FP8 Marlin on GPUs with hardware support for FP8