Skip to content

[mypy] Speed up mypy checking - #7056

Merged
youkaichao merged 2 commits into
vllm-project:mainfrom
DarkLight1337:faster-mypy
Aug 2, 2024
Merged

youkaichao merged 2 commits into
vllm-project:mainfrom
DarkLight1337:faster-mypy

Conversation

@DarkLight1337

@DarkLight1337 DarkLight1337 commented Aug 2, 2024 •

Copy link
Copy Markdown
Member

Turns out that placing the bare mypy command at the start instead of at the end can save around 30 seconds of time.

Since this is still too slow, I've also reinstated --follow-imports=skip for all files when run locally. The stricter checks are still being run in CI.

@github-actions

github-actions Bot commented Aug 2, 2024

Copy link
Copy Markdown

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@youkaichao

Copy link
Copy Markdown
Member

save around 30 seconds of time

even after this change, it still takes 31.22s in my dev machine. It used to take just seconds.

@DarkLight1337

Copy link
Copy Markdown
Member Author

See if this is fast enough for you now.

@youkaichao youkaichao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is much faster now! thanks for fixing it!

@youkaichao
youkaichao merged commit 3bb4b1e into vllm-project:main Aug 2, 2024
@DarkLight1337
DarkLight1337 deleted the faster-mypy branch August 2, 2024 02:54
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
Signed-off-by: Alvant <alvasian@yandex.ru>
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
Signed-off-by: LeiWang1999 <leiwang1999@outlook.com>
plasticchris pushed a commit to plasticchris/vllm that referenced this pull request Jul 20, 2026
michael-gpu pushed a commit to practical-inference/vllm-ampere-extended that referenced this pull request Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants