Repository navigation
[mypy] Speed up mypy checking - #7056
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge). To run full CI, you can do one of these:
🚀 |
even after this change, it still takes 31.22s in my dev machine. It used to take just seconds. |
|
See if this is fast enough for you now. |
youkaichao
left a comment
There was a problem hiding this comment.
it is much faster now! thanks for fixing it!
Signed-off-by: Alvant <alvasian@yandex.ru>
Signed-off-by: LeiWang1999 <leiwang1999@outlook.com>
Turns out that placing the bare
mypycommand at the start instead of at the end can save around 30 seconds of time.Since this is still too slow, I've also reinstated
--follow-imports=skipfor all files when run locally. The stricter checks are still being run in CI.