Repository navigation
[Bugfix][Multimodal] Don't validate model-built dummy inputs against mm limits - #65689
Merged
Merged
Conversation
Signed-off-by: cjackal <44624812+cjackal@users.noreply.github.com>
NickLucche
approved these changes
Nov 4, 2026
Member
|
/ci run |
NickLucche
enabled auto-merge (squash)
November 4, 2026 18:00
|
✅ Triggered Buildkite CI #99985 for commit ℹ️ This PR is 18 commits behind upstream |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes engine startup for Pixtral (+ other models with the same problem) when a modality is embedding-only (
--limit-mm-per-prompt '{"<modality>": 0}'with--enable-mm-embeds). This is the root cause of the failure observed in #65648.Claims
Validation
vllm serve mistralai/Pixtral-12B-2409 --tokenizer-mode mistral \ --limit-mm-per-prompt '{"image": 0}' --enable-mm-embedsDetails
#32493 added embedding input for disabled modality. It introduced the following split:
--limit-mm-per-promptand--enable-mm-embedsonce, in the renderer (BaseRenderercallinginfo.parse_mm_data).validate=False. Add embedding input functionality for disabled modalities [remake] #32493 switched both call sites:get_dummy_inputs)_get_cache_missing_itemsThe split is needed because
MultiModalBudgetprofiles each embedding-only modality withmm_counts={modality: 1}while its limit is 0. A dummy input that gets validated can never pass that check.4 models including Pixtral override
get_dummy_inputsand callself.info.parse_mm_data(dummy_mm_data)with the defaultvalidate=True. This PR fixes the processor-side contract violation. Without it, any deployment of these models that relies on embedding-only modalities still crashes at startup, including KV/EC consumers that should receive embeddings.Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.
BEFORE SUBMITTING, PLEASE READ https://docs.vllm.ai/en/latest/contributing (anything written below this line will be removed by GitHub Actions)