Repository navigation
[CI][DSv4.1] Give the MXFP8 linear test stub a params_dtype - #65552
Merged
Merged
Conversation
#64111 made FlashInferCutedslMxfp8LinearKernel.apply_weights take the output dtype from layer.params_dtype for unquantized inputs, which real linear layers set. The test_kernels.py stand-in never set it, so test_engram_wkv_prefetch_matches_inline fails with AttributeError on every nightly 4xB200 run since. bfloat16 matches the inputs the test feeds, so the output dtype is unchanged from before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: khluu <khluu000@gmail.com>
khluu
requested review from
AndreasKaratzas,
DarkLight1337 and
ywang96
as code owners
November 4, 2026 02:17
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix
:nvidia: (4xB200) DeepSeek-V4.1 NVIDIA Kernels(nightly). It has failed 12 times in a row since #64111 merged (latest: 99485):Root cause: #64111 changed
FlashInferCutedslMxfp8LinearKernel.apply_weights(vllm/model_executor/kernels/linear/mxfp8/flashinfer.py) to take the output dtype of unquantized inputs fromlayer.params_dtypeinstead ofx.dtype. Real vLLM linear layers always setparams_dtype, but the hand-built_Mxfp8Linearstand-in in this test did not.Why #64111's CI didn't catch it: the step is
optional: true(nightly only), so it never runs on PRs, and its source triggers don't includevllm/model_executor/kernels/linear/mxfp8/.Fix: set
params_dtype = torch.bfloat16on the stand-in, as a real linear layer would. The test feeds bf16 inputs, so the kernel's output dtype is the same as before #64111.Not a duplicate: no open PR touches this test or stub.
Test Plan
Not run locally (needs B200 GPUs). The step is nightly-only, so it will be confirmed by the next nightly after merge, or by a selected-step run of
dsv41-nvidia-kernels-4xb200on this PR.Notes
AI assistance (Claude Code) was used; reviewed by the submitter.
🤖 Generated with Claude Code