Repository navigation
Conversation
…=size Picks up vllm-project/flash-attention#216, which passes --compress-mode=size for CUDA >= 13 like vLLM's own extensions, plus vllm-project/flash-attention#199 (SM90 FP8 forward for head dim 512). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: mgoin <mgoin64@gmail.com>
mgoin
marked this pull request as ready for review
November 3, 2026 23:46
mgoin
requested review from
Harry-Chen,
LucasWilkinson and
tlrmchlsmth
as code owners
November 3, 2026 23:46
Member
Author
|
/ci run |
|
✅ Triggered Buildkite CI #99744 for commit ℹ️ This PR is 7 commits behind upstream |
Member
Author
|
Blocked on #60372 landing first |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Bump vllm-flash-attn to d8dca8f to pick up vllm-project/flash-attention#216, which compresses FA's fatbins with
--compress-mode=sizeon CUDA >= 13 as vLLM's own extensions already do. The x86_64 wheel shrinks by about 82 MB (about 25%).Claims
.sofiles.Validation
I built
_vllm_fa2_C/_vllm_fa3_Cfrom this branch's FA commit (CUDA 13.0,TORCH_CUDA_ARCH_LIST='7.5 8.0 8.6 8.9 9.0 10.0 11.0 12.0') and compared against the.sofiles in the v0.33.0 x86_64 wheel on PyPI (FA b273a02, also nvcc 13.0.88):.nv_fatbin_vllm_fa2_Cv0.33.0_vllm_fa2_Cthis PR_vllm_fa3_Cv0.33.0_vllm_fa3_Cthis PRcuobjdump -xelf/-xptxand hashed each kernel's.text.*section. FA2 has 2,904/2,904 SASS kernels identical to v0.33.0, and FA3 has 1,333/1,333. The 76 FA2 PTX files differ only in nvcc's per-TU_INTERNAL_<hash>symbol names.scaled_dot_product_attentionwith a max abs error of 0.0118.cuModuleLoadDataon B300 for one FA2 TU compiled to sm_100 SASS (4.4 MB uncompressed). It takes 12.7 ms uncompressed and 14.6 ms with--compress-mode=size, so about 2 ms per TU (about 0.45 ms per MB of SASS). With lazy module loading, only the TUs whose kernels run are loaded, once per process. Loading every image for one arch would cost about 100 ms for FA2 (sm_80) and about 60 ms for FA3 (sm_90a).FetchContentchecks out d8dca8f fromvllm-project/flash-attention.Details
VLLM_FA_GPU_FLAGSdoesn't inheritVLLM_GPU_FLAGS, so FA never got the--compress-mode=sizethatCMakeLists.txtsets for vLLM's own targets. By defaultfatbinarycompresses only PTX and debug images, which left all FA SASS stored raw.-Xfatbin=-compress-all(FlashInfer's approach) adds nothing on top of--compress-mode=sizeand gives larger output when used alone. Details are in the FA PR.fp8_kv_dequantguards (for example, it now requires head_dim 512). vLLM already restricts SM90 FA4 FP8-KV to head size 512 (fa_utils.pyflash_attn_supports_fp8), so no supported vLLM path changes.Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.
🤖 Generated with Claude Code