Repository navigation
[CI][Test] Validate manual NVFP4 fusion in NVIDIA Qwen mixed-precision test - #65495
Merged
Merged
Conversation
Signed-off-by: John Calderon <jcalderon@nvidia.com>
Contributor
|
/ci run |
|
✅ @johncalesp, CI is now available for this PR.
|
|
✅ Triggered Buildkite CI #99682 for commit |
arpera
approved these changes
Nov 3, 2026
khluu
added a commit
to atalman/vllm
that referenced
this pull request
Nov 4, 2026
Picks up the main fixes for the fusion E2E mixed-precision test (vllm-project#65495), the DeepSeek-V4.1 _Mxfp8Linear test (vllm-project#63921) and UMA KV cache sizing on DGX Spark (vllm-project#65413). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: khluu <khluu000@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The mixed-precision Qwen test expects four compiler-generated activation/quantization fusions—one per MLP—but the current NVIDIA Qwen implementation uses
CompilationMode.NONEand performs these fusionsexplicitly through maybe_fused_act_quant.
The test still reads the compiler’s fusion counter, which remains zero because the compiler pass does not run. Consequently, it fails with: Could not find 4 act_quant_fusion (found 0)
This is an outdated test expectation, rather than evidence of missing runtime fusion or a numerical mismatch. The original assertion reproduces on both Rubin and GB200.
This change updates the test to validate the current implementation:
The original model configuration and both test parameterizations remain. No production code or existing numerical tolerances are changed.
Following #51012 and #61107, NVIDIA Qwen uses explicit activation/quantization fusion with compilation disabled. This test retained its compiler-pass expectation, causing it to report zero matches despite runtime fusion executing correctly. Update it to validate the model’s actual fusion path.
Validation
Validation on Rubin and GB200 produced 37 passed per GPU: two adapted E2E cases and 35 existing compiler, manual-fusion, and ModelOpt detection checks. A negative control disabling fusion in one layer correctly failed on both GPUs, confirming that the test detects missing fusion.
Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.