[Bugfix][CI/Build][Hardware][AMD] Fix AMD tests, add HF cache, update CK FA, add partially supported model notes#6543
Merged
simon-mo merged 12 commits intovllm-project:mainfrom Jul 20, 2024
Conversation
Contributor
Author
|
/ready |
Collaborator
How is peft related to boto3 and awscli? Could you explain more? |
e503f7c to
2ce715f
Compare
e75ec14 to
196b461
Compare
Contributor
Author
It's linked via |
85ac29c to
cf793c0
Compare
675dfdd to
266af2d
Compare
Contributor
Author
|
Rebased, fixed one more test regression, and is all green except LM Eval Small Models which seems to be broken in main. Ready to ship! |
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 24, 2024
… CK FA, add partially supported model notes (vllm-project#6543)
Alvant
pushed a commit
to compressa-ai/vllm
that referenced
this pull request
Oct 26, 2024
… CK FA, add partially supported model notes (vllm-project#6543) Signed-off-by: Alvant <alvasian@yandex.ru>
LeiWang1999
pushed a commit
to LeiWang1999/vllm-bitblas
that referenced
this pull request
Mar 26, 2025
… CK FA, add partially supported model notes (vllm-project#6543) Signed-off-by: LeiWang1999 <leiwang1999@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix existing failures on AMD tests.
vllm_flash_attninvllm/spec_decode/draft_model_runner.py. This is not installed on ROCm, so the correct ROCm FA component is used instead.flashinferin a way that is not supported on ROCm. This installation is made optional: this shouldn't affect the esoteric case whereflashinferisn't correctly installed during CUDA tests, because 1. this will give an obvious error message at the beginning of the test and 2.flashinferModuleNotFoundErroris also pretty obvious.peft(due to [CORE] Adding support for insertion of soft-tuned prompts #4645) which is not currently installed in the AMD container. This in turns wants updatedbotocoreand henceboto3andawscli. These requirements are included inrequirements-test.txtbut are a small subset of it, so we do not install it for now. Once more AMD tests are enabled, we will begin usingrequirements-test.txtin earnest.PaliGemmafull-precision tests (added in [Model] Add PaliGemma #5189) and multimodal broadcast withPhi-3-Vision. This is due to issues during Triton compilation which is solved by updating Triton.Phi-3-VisionandPaliGemmaare still problematic under certain settings because too much shared memory is reserved by the Triton kernel on some devices. As a temporary workaround, CK FA is updated and used instead for the relevant tests and the associated warnings for partial model support in ROCm are added.PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]for bug fixes.[CI/Build]for build or continuous integration improvements.[Doc]for documentation fixes and improvements.[Model]for adding a new model or improving an existing model. Model name should appear in the title.[Frontend]For changes on the vLLM frontend (e.g., OpenAI API server,LLMclass, etc.)[Kernel]for changes affecting CUDA kernels or other compute kernels.[Core]for changes in the core vLLM logic (e.g.,LLMEngine,AsyncLLMEngine,Scheduler, etc.)[Hardware][Vendor]for hardware-specific changes. Vendor name should appear in the prefix (e.g.,[Hardware][AMD]).[Misc]for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
format.shto format your code.docs/source/if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with
rfc-requiredand might not go through the PR.What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
action-requiredlabel on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!