[ Misc ] non-uniform quantization via compressed-tensors for Llama#6515
[ Misc ] non-uniform quantization via compressed-tensors for Llama#6515robertgshaw2-redhat merged 28 commits intovllm-project:mainfrom
compressed-tensors for Llama#6515Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. Full CI run is still required to merge this PR so once the PR is ready to go, please make sure to run it. If you need all test signals in between PR commits, you can trigger full CI as well. To run full CI, you can do one of these:
🚀 |
compressed-tensors for Llamacompressed-tensors for Llama
|
/ready |
vllm/model_executor/models/utils.py
Outdated
| get_pp_group().world_size) | ||
| modules = torch.nn.ModuleList( | ||
| [PPMissingLayer() for _ in range(start_layer)] + | ||
| [layer_fn() for _ in range(start_layer, end_layer)] + |
There was a problem hiding this comment.
add prefix="" for make_layers, and pass prefix=f"{prefix}.{_}" to layer_fn
There was a problem hiding this comment.
okay sounds good
vllm/model_executor/models/llama.py
Outdated
|
|
||
| def __init__( | ||
| self, | ||
| prefix: str, |
There was a problem hiding this comment.
add default, and move it to the last arg
vllm/model_executor/models/llama.py
Outdated
| total_num_kv_heads=self.total_num_kv_heads, | ||
| bias=bias, | ||
| quant_config=quant_config, | ||
| layer_name=f"{prefix}.qkv_proj", |
There was a problem hiding this comment.
Are you sure?
This is the Linear which is the root. So its no longer a prefix but rather this is the final layer_name
There was a problem hiding this comment.
I also vote for prefix, because Linear is just another torch.nn.module. Unifying the naming might be more clear.
There was a problem hiding this comment.
updated to prefix
youkaichao
left a comment
There was a problem hiding this comment.
LGTM, let's change to prefix for the argument name.
vllm/model_executor/models/utils.py
Outdated
| def make_layers( | ||
| num_hidden_layers: int, layer_fn: Callable[[], torch.nn.Module] | ||
| num_hidden_layers: int, | ||
| layer_fn: Callable[[], torch.nn.Module], |
There was a problem hiding this comment.
typing is not correct. you can create a proto for type checking:
class LayerFn(Protocol):
def __call__(
self, prefix="",
) -> torch.nn.Module:
...
vllm/model_executor/models/gpt2.py
Outdated
| lambda prefix: GPT2Block(config, cache_config, quant_config), | ||
| prefix="") |
|
@robertgshaw2-neuralmagic please also merge the latest main and take care of the code in #6516 . |
vllm-project#6515) Signed-off-by: Alvant <alvasian@yandex.ru>
vllm-project#6515) Signed-off-by: LeiWang1999 <leiwang1999@outlook.com>
SUMMARY:
compressed-tensorsintegration to support for nonuniform quantizationlayer_namethoughllama.pyto enable selecting quantization scheme on layer-by-layer basislm-evaltest case for an example non-uniform modelFOLLOW UP PRs:
compressed-tensorsas a dependencyThis enables us to run a model with
fp8for some layers andfp16for other layersBEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]for bug fixes.[CI/Build]for build or continuous integration improvements.[Doc]for documentation fixes and improvements.[Model]for adding a new model or improving an existing model. Model name should appear in the title.[Frontend]For changes on the vLLM frontend (e.g., OpenAI API server,LLMclass, etc.)[Kernel]for changes affecting CUDA kernels or other compute kernels.[Core]for changes in the core vLLM logic (e.g.,LLMEngine,AsyncLLMEngine,Scheduler, etc.)[Hardware][Vendor]for hardware-specific changes. Vendor name should appear in the prefix (e.g.,[Hardware][AMD]).[Misc]for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
format.shto format your code.docs/source/if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with
rfc-requiredand might not go through the PR.What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
action-requiredlabel on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!