Skip to content

[XPU][CI]Increase memory for Quantization test and deselect timeout case in v1/shutdown - #65097

Merged
jikunshang merged 4 commits into
vllm-project:mainfrom
zxd1997066:xiangdong/quant_mem
Nov 3, 2026
Merged

jikunshang merged 4 commits into
vllm-project:mainfrom
zxd1997066:xiangdong/quant_mem

Conversation

@zxd1997066

@zxd1997066 zxd1997066 commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Overview

The purpose of this PR is to:

Claims

Validation

label agent runtime in CI estimated frequency (post merge only)
(BMG) Quantization 1xB70 11 min ~5.9 times/day

This doesn't put too much extra pressure on B70 resources.

Details


Pull Request Checklist
  • I used vLLM's /pr-checklist skill. (Mandatory for agents, optional for humans).

  • AI assistance was used during the creation of this PR.

  • Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.

  • Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.

  • Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.

  • Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.

@zxd1997066
zxd1997066 requested a review from a team November 2, 2026 07:02

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@mergify mergify Bot added ci/build quantization intel-gpu Related to Intel GPU labels Nov 2, 2026
Signed-off-by: zengxian <xiangdong.zeng@intel.com>
@khluu

khluu commented Nov 3, 2026

Copy link
Copy Markdown
Member

Kevin's review agent (Claude Code) here.

The memory bump in quantization_intel.yaml looks good. One question before I stamp the CI changes: this PR also adds a deselect to distributed_intel.yaml:

--deselect="tests/v1/shutdown/test_forward_error.py::test_llm_model_error[hmellor/tiny-random-LlamaForCausalLM-2-True]"

That turns off the TP=2 case of the engine-dies-on-model-error test on XPU, but the title and description only mention the Quantization memory change. Could you explain why it's being skipped (failure link or tracking issue), add that to the description, or move it to its own PR? Happy to approve once that's clarified.

@zxd1997066 zxd1997066 changed the title [XPU][CI]Increase memory for Quantization test [XPU][CI]Increase memory for Quantization test and deselect timeout case in v1/shutdown Nov 3, 2026
@zxd1997066

Copy link
Copy Markdown
Contributor Author

Kevin's review agent (Claude Code) here.

The memory bump in quantization_intel.yaml looks good. One question before I stamp the CI changes: this PR also adds a deselect to distributed_intel.yaml:

--deselect="tests/v1/shutdown/test_forward_error.py::test_llm_model_error[hmellor/tiny-random-LlamaForCausalLM-2-True]"

That turns off the TP=2 case of the engine-dies-on-model-error test on XPU, but the title and description only mention the Quantization memory change. Could you explain why it's being skipped (failure link or tracking issue), add that to the description, or move it to its own PR? Happy to approve once that's clarified.

Thanks for your review. I have updated the title and description.

@zxd1997066

Copy link
Copy Markdown
Contributor Author

/ci run

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

✅ Triggered Buildkite CI #99435 for commit bcf19f66a3f5.

@jikunshang
jikunshang merged commit 77d2790 into vllm-project:main Nov 3, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants