Repository navigation
[CI] Enroll Language Models steps that build mamba (waits on #58795) in automatic sharding (6 jobs) - #64604
Draft
Thangnguyenvn98 wants to merge 1 commit into
Draft
[CI] Enroll Language Models steps that build mamba (waits on #58795) in automatic sharding (6 jobs)#64604Thangnguyenvn98 wants to merge 1 commit into
Thangnguyenvn98 wants to merge 1 commit into
Conversation
…ject#58795) in automatic sharding Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thang Nguyen <thangnguyenvn647@gmail.com>
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Draft until #58795 merges. Enrolls the three Language Models steps that build mamba-ssm and causal-conv1d from source, and their AMD mirrors, in
automatic_shard(6 jobs). The source builds take most of a job's setup, and every shard would repeat them; #58795 prebuilds both in the test image, after which sharding these pays for itself. Part of the series that enrolls every remaining test step (#64590-#64599).Claims
language-models-test-extended-generationlanguage-models-tests-granite-l4-compatibilitylanguage-models-tests-hybridValidation
split_check.py: no step runs the whole suite in each of its jobs./ci runonce [CI] Prebuild mamba-ssm and causal-conv1d from pinned commits in a torch-keyed test-image stage #58795 has merged and this branch is rebased; until then the mamba builds would repeat per shard.Details
parallelism: 2and its--num-shards/--shard-idflags (step and mirror), so the planner owns the split.🤖 Generated with Claude Code
Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.