Skip to content

[Doc][Recipe] Kimi-K3: drop removed retention and RPC timeout envs - #64586

Open
namgyu-yun wants to merge 1 commit into
vllm-project:mainfrom
namgyu-yun:recipes/kimi-k3-drop-dead-envs
Open

namgyu-yun wants to merge 1 commit into
vllm-project:mainfrom
namgyu-yun:recipes/kimi-k3-drop-dead-envs

Conversation

@namgyu-yun

@namgyu-yun namgyu-yun commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Overview

Kimi-K3 sets VLLM_PREFIX_CACHE_RETENTION_INTERVAL and VLLM_RPC_TIMEOUT, which no longer exist in vllm/envs.py, so vLLM silently ignores both.

Claims

  • Drops both envs from every env block, guide export line and runbook env list.
  • No behaviour change: --prefix-cache-retention-interval already defaults to 0, the value set here, and nothing reads VLLM_RPC_TIMEOUT.

Validation

grep -c 'VLLM_RPC_TIMEOUT\|VLLM_PREFIX_CACHE_RETENTION_INTERVAL' vllm/envs.py  (main) → 0
grep 'prefix_cache_retention_interval:' vllm/config/cache.py                  (main) → default=0
node scripts/validate-source.mjs --source vllm --dir recipes  (vllm-project/recipes) → valid
Kimi-K3 generated JSON: RPC_TIMEOUT 3 → 0, RETENTION_INTERVAL 5 → 0; VLLM_USE_DIRECT_DCP_A2A 9 → 9 (control)

Details

Not served; the check is config-level only.


Pull Request Checklist
  • I used vLLM's /pr-checklist skill. (Mandatory for agents, optional for humans).

  • AI assistance was used during the creation of this PR.

  • Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.

  • Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.

  • Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.

  • Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.

@namgyu-yun
namgyu-yun requested a review from esmeetu as a code owner October 29, 2026 21:47

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@mergify

mergify Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

@mergify

mergify Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @namgyu-youn.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify Bot added the needs-rebase label Oct 30, 2026
@namgyu-yun
namgyu-yun force-pushed the recipes/kimi-k3-drop-dead-envs branch from 5215452 to 9c34124 Compare October 30, 2026 07:09
@mergify mergify Bot removed the needs-rebase label Oct 30, 2026
github-actions Bot added a commit to vllm-project/recipes that referenced this pull request Oct 30, 2026
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: namgyu-yun <namgyu.dev@gmail.com>
@namgyu-yun
namgyu-yun force-pushed the recipes/kimi-k3-drop-dead-envs branch from 9c34124 to 90781b3 Compare November 6, 2026 06:11
github-actions Bot added a commit to vllm-project/recipes that referenced this pull request Nov 6, 2026
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

This branch was successfully deployed

1 active deployment
recipes-preview — 90781b39 Deployed Nov 6, 2026 by namgyu-yun via dispatch #371
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant