Repository navigation
[Bugfix][Model] Nemotron 3.5 Super VL: support the native transformers config - #64506
Merged
tomeras91 merged 4 commits intoOct 29, 2026
Conversation
…den_size Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Roi Koren <roik@nvidia.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Roi Koren <roik@nvidia.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Roi Koren <roik@nvidia.com>
roikoren755
requested review from
DarkLight1337,
tomeras91 and
ywang96
as code owners
October 29, 2026 11:41
Contributor
|
Documentation preview: https://vllm--64506.org.readthedocs.build/en/64506/ |
1 task done
tomeras91
enabled auto-merge (squash)
October 29, 2026 11:46
Member
|
/ci run |
|
✅ Triggered Buildkite CI #98278 for commit ℹ️ This PR is 274 commits behind upstream |
4 of 6 tasks
roikoren755
deleted the
bugfix/support-nemotron-h-omni-without-trust-remote-code
branch
October 29, 2026 14:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Lets
NemotronH_Omni_Reasoning_V3checkpoints (Nemotron 3.5 Super VL) run without--trust-remote-codeon transformers ≥ 5.18.Related to #63470. Alternative to #64030 (see Details).
Claims
nvidia/NVIDIA-Nemotron-3.5-Super-VL-120B-A12B-*serves without--trust-remote-codewhen transformers ≥ 5.18 is installed.--trust-remote-code, older transformers versions, and the existing Nano VL / Nano Omni checkpoints behave as before.nemotron_h_omniconfig.supported_models.mdlists the architecture and the transformers ≥ 5.18 requirement for running without the flag.Validation
Serving:
vllm serve nvidia/NVIDIA-Nemotron-3.5-Super-VL-120B-A12B-NVFP4, with and without--trust-remote-code, on transformers 5.18.0. Both load and serve correctly. Without the fix, the run without the flag fails at model init with:Test:
main):No model eval: the change only selects which config field the projector size comes from, so weights and computation are unchanged.
Details
Root cause. Transformers 5.18 added a built-in
nemotron_h_omniconfig. The Super VL checkpoints declare"model_type": "nemotron_h_omni", soAutoConfigloads that class without remote code. The built-in class renamesvit_hidden_sizetovision_hidden_size, butNemotronH_Nano_VL_V2.__init__readconfig.vit_hidden_size.Fix. Read
vision_hidden_size, the name the built-in transformers config uses, and fall back tovit_hidden_size, which the remote-code configs use:nemotron_h_omni(≥ 5.18)vision_hidden_size--trust-remote-code)vit_hidden_sizevit_hidden_sizeTest. The
NemotronH_Omni_Reasoning_V3registry entry was an offline placeholder. It now points atnvidia/NVIDIA-Nemotron-3.5-Super-VL-120B-A12B-BF16withouttrust_remote_code, gated on transformers ≥ 5.18.0. The built-inNemotronHConfigderiveshybrid_override_patternfromlayers_block_typeand doesn't allow setting it, so the 2-layer override setslayers_block_typeinstead. The "Basic Models (Extra Initialization)" CI step selects this test.Why not #64030. #64030 copies the remote-code config and image processor into vLLM, about 520 lines. Transformers ≥ 5.18 already provides the config, and serving goes through
NanoNemotronVLProcessoreither way, so vLLM only needs this one field read. This matches #60623, which removed configs vLLM had copied once Transformers shipped them.Limitations.
--trust-remote-codeis still required.sound_config→audio_config, which vLLM doesn't read. The Super VL checkpoints have no audio, but a future checkpoint that loads with the built-in config and includes audio would have audio switched off with no error. Left for a follow-up.--trust-remote-codeuntil a release includes this fix. Its pinned image (v0.31.0) doesn't have it.Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.
🤖 Generated with Claude Code