Repository navigation
[MM] Support mm_device_do_normalize for gemma3. - #64487
Merged
Merged
Conversation
mergify
Bot
added
multi-modality
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
noooop
changed the title
noooop
changed the title
Contributor
|
Documentation preview: https://vllm--64487.org.readthedocs.build/en/64487/ |
noooop
marked this pull request as ready for review
November 2, 2026 06:19
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
DarkLight1337
approved these changes
Nov 2, 2026
Member
|
/ci run |
|
✅ Triggered Buildkite CI #99110 for commit ℹ️ This PR is 2 commits behind upstream |
Contributor
Author
|
/ci run |
|
✅ Triggered Buildkite CI #99408 for commit |
Contributor
Author
|
/ci run |
noooop
enabled auto-merge (squash)
November 3, 2026 02:56
|
✅ Triggered Buildkite CI #99426 for commit ℹ️ This PR is 1 commit behind upstream |
github-actions
Bot
added
the
ready
Contributor
Author
|
/ci retry |
|
✅ Triggered Buildkite CI #99471 for commit |
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Support mm_device_do_normalize for gemma3.
Claims
Validation
Test for FusedMMInputNorm
Test for Models
Details
The BCHW layout can be converted into the BCL layout through a simple view, so fused_mm_input_norm_triton can support this format without adding a new kernel—lucky.
Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.