Repository navigation
[Doc] Fix MiniMax-M3 docstring cross-references - #64474
Merged
vllm-bot merged 3 commits intoOct 29, 2026
Merged
Conversation
Signed-off-by: freyfwt <freytian1996@gmail.com> Co-authored-by: Codex <noreply@openai.com>
freyfwt
requested review from
dllehr-amd,
hongxiayang and
tjtanaa
as code owners
October 29, 2026 07:45
hmellor
reviewed
Oct 29, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
hmellor
approved these changes
Oct 29, 2026
hmellor
enabled auto-merge (squash)
October 29, 2026 11:12
Member
|
/ci run |
|
✅ Triggered Buildkite CI #98268 for commit ℹ️ This PR is 6 commits behind upstream |
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Format tensor shapes and array indexing as inline code in three MiniMax-M3 AMD docstrings, fixing the seven unresolved cross-references that abort strict API documentation builds.
Fixes #64469. The failing Read the Docs build contains the original warnings.
Claims
head,:n, andrcross-references.Validation
Python 3.12.13 with the repository-pinned
requirements/docs.txt:fa3b9d1377219247060d3c8b49eae199c9e7e154: exit 1, reproducing all seven warnings (head×2,:n×4,r×1); output:Aborted with 7 warnings in strict mode!.Documentation built in 112.08 seconds.<code>spans across the three API pages.All applicable pre-commit hooks passed on the three changed files, including Ruff and mypy (Python 3.11 target). Hooks with no matching changed files were excluded from environment setup.
git diff --checkand a docstring-stripped AST comparison passed.Hosted API documentation validation requires the
build-docslabel because this PR changes onlyvllm/; that label needs to be applied by a maintainer.Hosted CI is currently blocked by the pre-run-check contributor gate: it found one merged PR for the author, below the required four, and no accepted
verified/ready/ready-run-all-testslabel. Hosted pre-commit and formatting checks were skipped. Read the Docs build 35491934 was also skipped, so its success status is not a documentation build result. The local before/after strict-build evidence above is the completed validation.Details
Use the inline-code style already present in these docstrings. Searches for #64469 and related MiniMax docstring fixes found no existing implementation. AI assistance was used for implementation, validation, and this description.
Pull Request Checklist
/pr-checklistskill. (Mandatory for agents, optional for humans).