Skip to content

[misc][distributed] fix pp missing layer condition#6446

Merged
youkaichao merged 1 commit intovllm-project:mainfrom
youkaichao:fix_pp_missing
Jul 15, 2024
Merged

[misc][distributed] fix pp missing layer condition#6446
youkaichao merged 1 commit intovllm-project:mainfrom
youkaichao:fix_pp_missing

Conversation

@youkaichao
Copy link
Member

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only trigger fastcheck CI to run, which consists only a small and essential subset of tests to quickly catch errors with the flexibility to run extra individual tests on top (you can do this by unblocking test steps in the Buildkite run).

Full CI run is still required to merge this PR so once the PR is ready to go, please make sure to run it. If you need all test signals in between PR commits, you can trigger full CI as well.

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

Copy link
Contributor

@yudian0504 yudian0504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youkaichao
Copy link
Member Author

just curious, how can you figure it out so quickly?

I'm still setting up the correctness test of pipeline parallel.

@youkaichao youkaichao merged commit 4cf256a into vllm-project:main Jul 15, 2024
@youkaichao youkaichao deleted the fix_pp_missing branch July 15, 2024 17:32
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 24, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
Signed-off-by: LeiWang1999 <leiwang1999@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants