Repository navigation
[CI] Enroll five steps and four AMD mirrors in automatic sharding - #64355
Merged
khluu merged 2 commits intoNov 2, 2026
Merged
Conversation
Contributor
Author
|
/ci run |
|
✅ Triggered Buildkite CI #98080 for commit |
This was referenced Oct 29, 2026
Thangnguyenvn98
force-pushed
the
agent/automatic-shard-batch-14
branch
from
October 30, 2026 18:40
1367a97 to
73207f4
Compare
Contributor
Author
|
/ci run |
|
✅ Triggered Buildkite CI #98766 for commit |
Also name the one file that DeepSeek V4 Kernels' glob matches, so the shard planner can find it in the checkout. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thang Nguyen <thangnguyenvn647@gmail.com>
The pipeline generator only shards a step whose commands after the first pytest are all plain pytest, so on script, pip-install, export and find|xargs steps the flag is ignored and the step runs as one job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thang Nguyen <thangnguyenvn647@gmail.com>
Thangnguyenvn98
force-pushed
the
agent/automatic-shard-batch-14
branch
from
October 31, 2026 00:38
73207f4 to
7799a54
Compare
Contributor
Author
|
/ci run |
|
✅ Triggered Buildkite CI #98860 for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Enrolls five steps and four of their AMD mirrors in
automatic_shard, continuing the earlier enrollment batches (#64115, #64174, #64181). Each runs as one job today, unchanged, and splits without another CI change once its tests outgrow one job. One command changes: DeepSeek V4 Kernels (H100) names the single file its glob matched, so the shard planner can find it.Claims
language-models-test-pplmulti-modal-models-standard-1-qwen2enginedeepseek-v4-kernel-test-h100kernels-deepgemm-test-h100Validation
kernels/test_fused_deepseek_v4_*.pymatches onlytest_fused_deepseek_v4_qnorm_rope_kv_insert.pytoday, the one test file the step'ssource_file_dependencieslists. In build 98080 that command collected and passed the same 215 tests as on main./ci runon the previous head (98766) plus a build scoped to the AMD mirrors it leaves behind the block step (98793): every job passed. A fresh/ci runfollows on this head.Details
pip installbetween pytest commands), with their mirrors; the generator ignored the flag on them, so this PR no longer touches them.test_arg_utils.py,test_config.pyandtest_logger.pyassert on logs; none starts an engine (test_logger.py'sLLM(...)raises before engine init), and the step stays one job in its current order.timeout_in_minutesstays per job. Fallback-aware timeouts belong in a central timeout setting.🤖 Generated with Claude Code
Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.