Skip to content

[CI] Fix mypy multimodels tests folder - #64342

Merged
yewentao256 merged 10 commits into
mainfrom
wentao-fix-mypy-multiple-model
Oct 30, 2026
Merged

[CI] Fix mypy multimodels tests folder#64342
yewentao256 merged 10 commits into
mainfrom
wentao-fix-mypy-multiple-model

Conversation

@yewentao256

@yewentao256 yewentao256 commented Oct 28, 2026

Copy link
Copy Markdown
Member

Overview

Fix mypy multimodels tests folder

@yewentao256
fix mypy multimodels
762ebff 
Signed-off-by: yewentao256 <zhyanwentao@126.com>
@yewentao256 yewentao256 added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 28, 2026
@yewentao256

yewentao256 commented Oct 28, 2026

Copy link
Copy Markdown
Member Author

/ci run

@github-actions

github-actions Bot commented Oct 28, 2026

Copy link
Copy Markdown

✅ Triggered Buildkite CI #98059 for commit 762ebff04d75.

claude[bot]
claude Bot reviewed Oct 28, 2026
View reviewed changes

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@mergify mergify Bot added pooling llama Related to Llama models multi-modality Related to multi-modality (#4194) mistral Related to Mistral models qwen Related to Qwen models kimi k3 glm nvidia labels Oct 28, 2026
@yewentao256 yewentao256 mentioned this pull request Oct 28, 2026
Open
1 task done
@mergify

mergify Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @yewentao256.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify Bot added the needs-rebase label Oct 28, 2026
@hmellor @claude
Fix mypy errors at source and drop unneeded test workarounds
7c33975 
- Pass DummyOptions defaults to Field by keyword so mypy sees them as optional
- Give SupportsLoRA.lora_manager a None default so explicit subclasses are not
  implicitly abstract
- Revert getattr/noqa B009, type: ignore[abstract] and dict() workarounds that
  mypy does not need

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor @claude
Restore original granite_speech input and mistral3 uint8 coverage
b343898 
- Pass granite_speech audio as a bare array again; the (audio, sr) tuple
  changed the HF and vLLM inputs and is not needed for mypy
- Check every raw pixel value is uint8 instead of only those reached by zip

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@github-project-automation github-project-automation Bot moved this to Ready in NVIDIA Oct 29, 2026
@hmellor

hmellor commented Oct 29, 2026

Copy link
Copy Markdown
Member

/ci run

@github-actions

github-actions Bot commented Oct 29, 2026

Copy link
Copy Markdown

❌ This PR is 80 commits behind upstream main. The bot could not merge upstream main into this branch (API returned 422: merge conflict between base and head). No new CI build was started. Either merge or rebase onto the latest main yourself and rerun /ci run, or use /ci run --allow-stale to test this branch as is.

@hmellor
Merge branch 'main' into wentao-fix-mypy-multiple-model
43c29c9 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor

hmellor commented Oct 29, 2026

Copy link
Copy Markdown
Member

/ci run

@github-actions

github-actions Bot commented Oct 29, 2026

Copy link
Copy Markdown

✅ Triggered Buildkite CI #98351 for commit 43c29c9b3944.

@mergify

mergify Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Hi @yewentao256, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

@mergify mergify Bot removed the needs-rebase label Oct 29, 2026
@yewentao256
fix
bd553a0 
Signed-off-by: yewentao256 <zhyanwentao@126.com>
@yewentao256

yewentao256 commented Oct 29, 2026

Copy link
Copy Markdown
Member Author

/ci run

@github-actions

github-actions Bot commented Oct 29, 2026

Copy link
Copy Markdown

✅ Triggered Buildkite CI #98359 for commit 4ce2918d273f.

ℹ️ This PR is 2 commits behind upstream main. Merged upstream main into this branch as 4ce2918d273f before starting CI. Pull the branch before pushing more changes.

@yewentao256
yewentao256 enabled auto-merge (squash) October 29, 2026 17:12
@yewentao256
fix
e40df1f 
Signed-off-by: yewentao256 <zhyanwentao@126.com>
@yewentao256

yewentao256 commented Oct 29, 2026

Copy link
Copy Markdown
Member Author

/ci run

@github-actions

github-actions Bot commented Oct 29, 2026

Copy link
Copy Markdown

✅ Triggered Buildkite CI #98412 for commit bff1b6f5e474.

ℹ️ This PR is 23 commits behind upstream main. Merged upstream main into this branch as bff1b6f5e474 before starting CI. Pull the branch before pushing more changes.

@mergify

mergify Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Hi @yewentao256, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

@yewentao256
fix precommit
39fb022 
Signed-off-by: yewentao256 <zhyanwentao@126.com>
@yewentao256

yewentao256 commented Oct 29, 2026

Copy link
Copy Markdown
Member Author

/ci run

@github-actions

github-actions Bot commented Oct 29, 2026

Copy link
Copy Markdown

✅ Triggered Buildkite CI #98487 for commit a9eb1ad4565d.

ℹ️ This PR is 9 commits behind upstream main. Merged upstream main into this branch as a9eb1ad4565d before starting CI. Pull the branch before pushing more changes.

@yewentao256
yewentao256 merged commit 83bae49 into main Oct 30, 2026
168 checks passed
@yewentao256
yewentao256 deleted the wentao-fix-mypy-multiple-model branch October 30, 2026 00:42
@github-project-automation github-project-automation Bot moved this from Ready to Done in NVIDIA Oct 30, 2026
@gty111 gty111 mentioned this pull request Oct 30, 2026
Merged
micah-wil added a commit to ROCm/vllm that referenced this pull request Oct 30, 2026
@micah-wil @cursoragent
[CI] Fix mypy errors in GLM-5.3 video timestamp test
b50b65f 
Narrow MultiModalKwargsItem and NestedTensors types in test_glm5_raw_video_timestamps_follow_sampled_frames, which landed in vllm-project#64071 concurrently with vllm-project#64342 enabling stricter mypy for tests/models/multimodal.

Signed-off-by: Micah Williamson <micah.williamson@amd.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@ashraf-bhuiyan ashraf-bhuiyan mentioned this pull request Nov 4, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claude claude[bot] claude[bot] left review comments
@hmellor hmellor hmellor approved these changes
@noooop noooop Awaiting requested review from noooop noooop is a code owner
@tomeras91 tomeras91 Awaiting requested review from tomeras91 tomeras91 is a code owner
@DarkLight1337 DarkLight1337 Awaiting requested review from DarkLight1337 DarkLight1337 is a code owner
@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner
@AndreasKaratzas AndreasKaratzas Awaiting requested review from AndreasKaratzas AndreasKaratzas is a code owner
@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner
@youkaichao youkaichao Awaiting requested review from youkaichao youkaichao is a code owner
@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner
@mgoin mgoin Awaiting requested review from mgoin mgoin is a code owner
@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth tlrmchlsmth is a code owner
@houseroad houseroad Awaiting requested review from houseroad houseroad is a code owner
@ProExpertProg ProExpertProg Awaiting requested review from ProExpertProg ProExpertProg is a code owner

Assignees

No one assigned

Labels

glm k3 kimi llama Related to Llama models mistral Related to Mistral models multi-modality Related to multi-modality (#4194) nvidia pooling qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed

Projects

NVIDIA
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yewentao256 @hmellor @vllm-agent