Repository navigation
[Bugfix][Rust Frontend][ZMQ] Run ZMQ transport I/O on the dedicated runtime - #64294
Merged
Merged
Conversation
Signed-off-by: reidliu41 <reid201711@gmail.com>
reidliu41
marked this pull request as ready for review
October 28, 2026 14:28
BugenZhao
approved these changes
Nov 2, 2026
BugenZhao
left a comment
Member
There was a problem hiding this comment.
Thanks! This is a good catch!
Member
|
/ci run |
|
✅ Triggered Buildkite CI #99162 for commit ℹ️ This PR is 312 commits behind upstream |
Contributor
Author
|
Thank you for the merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Create and connect Rust frontend ZMQ sockets on the dedicated runtime so
socket readiness and background transport tasks use the same Tokio I/O
driver. Caller-runtime load or shutdown can no longer delay or terminate
engine communication.
Claims
ZMQ runtime instead of the runtime that calls
EngineCoreClient::connect.down.
runtime.
Validation
A Linux epoll probe with a mock engine confirmed the runtime ownership change:
Details
Tokio associates TCP resources with the I/O driver of the runtime active when
those resources are created. Transport setup previously ran on the caller
runtime, while
build_zmq_runtime()was called only after the sockets hadalready been bound or connected. Background transport tasks ran on the
dedicated runtime, but socket readiness was still driven by the caller
runtime.
The dedicated runtime is now created before transport setup. The complete
connection path runs on that runtime, and the same runtime is passed into
from_connectedfor background task execution and lifetime ownership.Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.