Repository navigation
[CI] Enroll the PYTHONPATH steps in automatic sharding (waits on ci-infra#825) - #64128
Draft
Thangnguyenvn98 wants to merge 3 commits into
Draft
Thangnguyenvn98 wants to merge 3 commits into
Thangnguyenvn98 wants to merge 3 commits into
Conversation
…r) automatically Their commands set PYTHONPATH, which hides the sharding plugin until ci-infra#825 installs it into site-packages. The API Server step and its AMD mirror move from fixed shards to automatic ones: parallelism, the shard flags and the shard-1 guard come out. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thang Nguyen <thangnguyenvn647@gmail.com>
Closed
6 tasks done
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thang Nguyen <thangnguyenvn647@gmail.com>
Its command sets PYTHONPATH= too, so it waits on the same ci-infra#825. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thang Nguyen <thangnguyenvn647@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Enrolls every remaining step whose pytest commands set
PYTHONPATH, with its AMD mirror, in automatic sharding. Draft until ci-infra#825 merges: settingPYTHONPATHreplaces the path the sharding plugin is installed on, so today every shard of these steps fails withNo module named 'runtime_shard_plugin'(seen in #62513's build 97706, which dropped Spec Decode for this reason). ci-infra#825 installs the plugin into site-packages, where a command's ownPYTHONPATHcan't hide it.Claims
lm-eval-spec-decode-4xb200entrypoints-integration-api-serveramd-entrypoints-integration-api-serveramd-lm-eval-spec-decode-4xb200rust-frontend-serve-admin-coverageamd-rust-frontend-serve-admin-coveragedev/rpccommand and the--num-shards/--shard-idflags give way to the planner, so new test files no longer need placing by hand.Validation
PYTHONPATHproblem; the/ci runafter ci-infra#825 merges is the check for it./ci run, plus a build scoped to the optional Spec Decode step and the AMD mirrors/ci runleaves out, once ci-infra#825 is merged.Details
entrypoints/serve/dev/rpcnow runs in whichever shard the plan gives it rather than always in shard 1. One file,scale_out/ec_integration/test_scale_out_ec_e2e.py, has no timing on main and is counted at the planner's default.timeout_in_minutesstays per job; fallback-aware timeouts belong in a central timeout setting./ci runonce it merges.🤖 Generated with Claude Code
Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.