Skip to content

[Misc] Revert "[NIXL] Bump NIXL version to 1.5.1" (#63817) - #64085

Merged
NickLucche merged 2 commits into
vllm-project:mainfrom
jh-nv:revert-nixl-1.5.1
Oct 27, 2026
Merged

NickLucche merged 2 commits into
vllm-project:mainfrom
jh-nv:revert-nixl-1.5.1

Conversation

@jh-nv

@jh-nv jh-nv commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Overview

Revert #63817, returning the NIXL pin to 1.5.0 in requirements/kv_connectors.txt (CUDA 13) and requirements/kv_connectors_cu12.txt (CUDA 12).

Reason:

The NIXL team is calling back the 1.5.1, as there is a incidental bump of libfabric version (2.7.0) included, which would impact EFA users.

Claims

Validation

  • Dependency resolution, x86_64 and aarch64, both files: nixl, nixl-cu12 and nixl-cu13 all resolve to 1.5.0.
    uv pip compile --python-version 3.12 --python-platform x86_64-manylinux_2_28 --torch-backend cu129 requirements/kv_connectors.txt
    # repeated for aarch64-manylinux_2_28 and requirements/kv_connectors_cu12.txt
  • pre-commit run --files requirements/kv_connectors.txt requirements/kv_connectors_cu12.txt: passed.
  • No GPU run. 1.5.0 was the pin in main until [NIXL] Bump NIXL version to 1.5.1 #63817 merged on 2026-10-26.

Details

This also undoes the LIBFABRIC changes from 1.5.1: the plugin goes back to needing libfabric 1.20 or newer instead of 2.7 or newer, and the ai-dynamo/nixl#2425 fix for context-independent CUDA allocations is no longer included.

Not a duplicate: no open PR reverts #63817.

AI assistance (Claude Code) was used to prepare this PR.


Pull Request Checklist
  • I used vLLM's /pr-checklist skill. (Mandatory for agents, optional for humans).

  • AI assistance was used during the creation of this PR.

  • Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.

  • Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.

  • Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.

  • Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.

🤖 Generated with Claude Code

This reverts commit 7a1ebe4, returning
the CUDA 12 and CUDA 13 NIXL pins to 1.5.0.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Jie Hao <jihao@nvidia.com>
@jh-nv
jh-nv marked this pull request as ready for review October 27, 2026 16:05
@jh-nv
jh-nv requested a review from NickLucche as a code owner October 27, 2026 16:05

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@NickLucche NickLucche added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 27, 2026
@NickLucche

Copy link
Copy Markdown
Member

/ci run

@NickLucche
NickLucche enabled auto-merge (squash) October 27, 2026 17:58
@github-actions

Copy link
Copy Markdown

✅ @jh-nv, CI is now available for this PR.

  • /ci run starts upstream CI; /amd-ci run starts AMD CI only.
  • Run commands test your branch with every commit currently on its upstream target branch. If it is behind, the bot merges the target branch into it first (pull before pushing again). Append --allow-stale to a run command to test an outdated branch as is, at your own risk.
  • /ci retry retries failed jobs in the CI build for the current PR head. If the current head has no CI build, it starts a new CI build for the current head containing only jobs that failed in the latest earlier CI build for this PR.
  • /amd-ci retry retries failed jobs in AMD CI for the current PR head. Use /amd-ci run when the current head has no AMD CI build.
  • /ci cancel cancels scheduled or running CI builds for this PR branch; /amd-ci cancel does the same for AMD CI only.

@github-actions

Copy link
Copy Markdown

✅ Triggered Buildkite CI #97699 for commit 054e91d6cb51.

ℹ️ This PR is 9 commits behind upstream main. Merged upstream main into this branch as 054e91d6cb51 before starting CI. Pull the branch before pushing more changes.

@NickLucche NickLucche changed the title Revert "[NIXL] Bump NIXL version to 1.5.1" (#63817) [Misc] Revert "[NIXL] Bump NIXL version to 1.5.1" (#63817) Oct 27, 2026
@NickLucche

Copy link
Copy Markdown
Member

/ci run

@github-actions

Copy link
Copy Markdown

✅ CI is already running for this commit: https://buildkite.com/vllm/ci/builds/97699

@NickLucche
NickLucche merged commit 0855def into vllm-project:main Oct 27, 2026
438 of 439 checks passed
@erezzarum erezzarum mentioned this pull request Oct 29, 2026
5 of 6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build kv-connector ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants