Repository navigation
[Bugfix] Forward launch grid to Triton kernel overrides - #63999
Merged
Isotr0py merged 2 commits intoOct 27, 2026
Merged
Conversation
The kernel dispatcher's KernelOverride dropped the caller's launch grid, so platforms like vllm-ascend could not remap grids (e.g. to physical core counts). Triton kernel implementations are now swapped in directly, launching natively and staying inlinable as Triton device functions; non-Triton implementations are wrapped, receive the grid via __getitem__, and delegate compile-only warmup. Co-authored-by: opencode-agent <noreply@opencode.ai> Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
Author
|
@Isotr0py Can you please take a look at this change? It fixed some bug we hit when add triton kernels in vllm-ascend. Thanks. |
Isotr0py
enabled auto-merge (squash)
October 27, 2026 13:06
Member
|
/ci run |
github-actions
Bot
added
the
ready
|
✅ Triggered Buildkite CI #97626 for commit ℹ️ This PR is 41 commits behind upstream |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The kernel dispatcher's KernelOverride dropped the caller's launch grid, so platforms could not remap grids (e.g. to physical core counts). Triton kernel implementations are now swapped in directly, launching natively and staying inlinable as Triton device functions; non-Triton implementations are wrapped, receive the grid via getitem, and delegate compile-only warmup.
This PR fixes three gaps in the Triton kernel dispatcher: (1) the launch grid is now forwarded to overrides instead of being dropped, (2) Triton device functions called from inside other kernels can be overridden without breaking the outer kernel's compilation, and (3) JIT warmup is delegated to the override instead of failing.
Claims
Validation
Details
Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.