Repository navigation
[ROCm][Perf] Make MXFP4 the default indexer K cache dtype for DeepSeek-V4 - #63669
Merged
Merged
Conversation
shen-shanshan
requested review from
ProExpertProg,
WoosukKwon,
dllehr-amd,
houseroad,
mgoin,
robertgshaw2-redhat,
tjtanaa,
tlrmchlsmth,
yewentao256 and
youkaichao
as code owners
October 26, 2026 06:25
22 of 30 tasks
Contributor
Author
|
/ci run |
|
✅ Triggered Buildkite CI #97226 for commit |
Contributor
Author
|
/ci retry |
|
✅ Queued 1 failed job(s) for retry in Buildkite CI #97226. |
Signed-off-by: shen-shanshan <467638484@qq.com>
Signed-off-by: shen-shanshan <467638484@qq.com>
shen-shanshan
force-pushed
the
rocm-dsv4-perf
branch
from
October 26, 2026 10:20
d2514d7 to
9c3b549
Compare
Contributor
Author
|
/ci run |
|
✅ Triggered Buildkite CI #97269 for commit ℹ️ This PR is 1 commit behind upstream |
Fangzhou-Ai
approved these changes
Oct 26, 2026
10 of 11 tasks
Micador
pushed a commit
to Micador/vllm
that referenced
this pull request
Oct 27, 2026
…k-V4 (vllm-project#63669) Signed-off-by: shen-shanshan <467638484@qq.com> Co-authored-by: vllm-agent <claw@inferact.ai> Signed-off-by: Christopher Mackenzie <christopher.mackenzie.software@gmail.com>
Micador
pushed a commit
to Micador/vllm
that referenced
this pull request
Oct 27, 2026
…k-V4 (vllm-project#63669) Signed-off-by: shen-shanshan <467638484@qq.com> Co-authored-by: vllm-agent <claw@inferact.ai> Signed-off-by: Christopher Mackenzie <christopher.mackenzie.software@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
#60834 brought the paged MXFP4 sparse indexer (dense path) to DeepSeek-V4 on ROCm gfx950. It was opt-in:
--attention-config '{"indexer_kv_dtype": "mxfp4"}'Its measurements show the MXFP4 indexer is better than the FP8 one on almost every axis:
The results are copied below. This PR therefore makes MXFP4 the default indexer K cache dtype for DeepSeek-V4 (
model_type == "deepseek_v4", i.e. V4-Pro / V4-Flash) on ROCm CDNA4, and logs that it is enabled.Claims
Nothing else changes:
Validation
Benchmark (from #60834, DeepSeek-V4-Pro)
Fixed sequence length (
8k1k, TP8, MTP=2):Agentic replay (DP8, MTP=3, prefix caching):
Accuracy (from #60834, DeepSeek-V4-Pro)
GSM8K:
GPQA Diamond:
Details
Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.
Need help on this PR? Tag
@codesmith-botwith what you need.