[Bugfix] Require triton >= 3.0.0 to resolve issue with MoE and TP>1#6304
Closed
tdoublep wants to merge 1 commit intovllm-project:mainfrom
Closed
[Bugfix] Require triton >= 3.0.0 to resolve issue with MoE and TP>1#6304tdoublep wants to merge 1 commit intovllm-project:mainfrom
tdoublep wants to merge 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com>
Member
Author
|
Hmm closing this for now since it seems to conflict with torch version currently being used: we will need to wait for torch to go to Triton 3.0.0 i guess |
Collaborator
|
To update this, we will need to wait for torch 3.0 to release, followed by xformers, vllm-flash-attn and flashinfer. |
Collaborator
|
I think #6140 can serve as a solution for triton <3.0.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6103 via triton-lang/triton#4295
This would make #6140 redundant but let's see if bumping Triton causes any issues in CI.