Repository navigation
[Rust Frontend] Refresh rust/AGENTS.md with ownership and design conventions - #62721
Merged
Merged
Conversation
…entions
Replace stale guidance ("fine to break API", unconditional file splitting)
and add the conventions reviewers keep applying to Rust frontend PRs: crate
ownership, design principles, Python frontend parity, parser rules,
validation by claim, and a PR note for intentional deviations. Link the
guide from the root AGENTS.md domain-specific guides.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
esmeetu
approved these changes
Oct 21, 2026
Member
Author
|
/ci run |
|
✅ Triggered Buildkite CI #96371 for commit ℹ️ This PR is 50 commits behind upstream |
bantianyue
pushed a commit
to bantianyue/vllm
that referenced
this pull request
Oct 28, 2026
…entions (vllm-project#62721) Signed-off-by: Bugen Zhao <i@bugenzhao.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: vllm-agent <claw@inferact.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Refresh
rust/AGENTS.md, which has not changed since the Rust frontend moved into this repo (#43283), and link it from the rootAGENTS.mddomain-specific guides.Claims
winnow,thiserror-ext,expect-test,for_test(), nextest, and Unix-only rules as written.Validation
pre-commitpasses on the commit, includingcheck-agent-files(root 158/200 lines,rust/AGENTS.md116/300) andmarkdownlint-cli2.rust/. The draft was corrected where it disagreed with intentional code:NoopCLI flags, one tool parser type registered under several names, token-identity markers only where the parser receives decoded tokens, and the scripted in-process mock engine versus the random-tokenvllm-mock-enginebinary.Details
rust/AGENTS.md.AGENTS.mdand thepr-checklistskill is left out.rust/.Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.
🤖 Generated with Claude Code