Repository navigation
[CI][AMD] Deselect distributed tests in the MI300 Model Executor step - #62680
Merged
AndreasKaratzas merged 1 commit intoOct 20, 2026
Conversation
The step runs on a single GPU (agent_pool: mi300_1), but its pytest command does not deselect distributed tests. vllm-project#55490 added a tp=2 weight cache test together with the "not distributed" filter in test_areas/model_executor.yaml; test-amd.yaml kept the old command, so the test is collected and the second worker fails with "DP adjusted local rank 1 is out of bounds for 1 devices". Signed-off-by: Stefan Koncarevic <stefan.koncarevic@amd.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Collaborator
Author
|
/ci run |
|
❌ @stefankoncarevic, A reviewer with write access must run |
stefankoncarevic
added
the
ready
Collaborator
Author
|
/ci run |
|
✅ @stefankoncarevic, CI is now available for this PR.
|
Collaborator
Author
|
/amd-ci run |
|
✅ Triggered Buildkite CI #96132 for commit |
|
✅ Triggered Buildkite AMD CI #15031 for commit |
AndreasKaratzas
approved these changes
Oct 20, 2026
bantianyue
pushed a commit
to bantianyue/vllm
that referenced
this pull request
Oct 28, 2026
…vllm-project#62680) Signed-off-by: Stefan Koncarevic <stefan.koncarevic@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failure
(MI300) Model Executorin AMD CI nightly 15028, the only failure among 1282 passing tests:The root cause is in the second worker:
The cause
#55490 added
test_ipc_cache_cold_start_and_warm_restart_tp2_epwith@pytest.mark.distributed(num_gpus=2)and, in the same commit, addedand (not distributed)to the pytest command in.buildkite/test_areas/model_executor.yaml, for the H200 step and its AMD mirror alike..buildkite/test-amd.yamlkept-m '(not slow_test)', and that step runs onagent_pool: mi300_1, so a tp=2 test is collected on a single GPU and the second worker has no device to bind.The change
The same filter as the upstream step. Collection over
model_executorgoes from 1342 selected and 33 deselected to 1341 and 34; the tp=2 test is the only one removed.Tests
The test itself is healthy: with two GPUs visible it passes on MI300 (gfx942, ROCm 10.0), 1 passed in 267.66s. With one GPU visible it reproduces the CI assertion verbatim, and with this change it is deselected instead of collected.
Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.