Repository navigation
Conversation
Transformers 5.20 splits SmolVLM image features into blocks of the vision patch size instead of the image token count, so the HF reference forward fails for SmolVLM2-2.2B. Fixed upstream in huggingface/transformers#49725, which is not in 5.20.2. Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Andreas Karatzas <akaratza@amd.com>
AndreasKaratzas
marked this pull request as ready for review
October 20, 2026 05:29
AndreasKaratzas
requested review from
DarkLight1337 and
ywang96
as code owners
October 20, 2026 05:29
Member
Author
|
/ci run |
|
✅ Triggered Buildkite CI #96077 for commit |
hmellor
approved these changes
Oct 20, 2026
AndreasKaratzas
enabled auto-merge (squash)
October 20, 2026 05:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
registry.py: cap the SmolVLM HF reference attransformers<=5.19with anhfreason, sotest_common.pyskips the HF-vs-vLLM comparison while vLLM-side tests keep running.#61983 bumped Transformers to 5.20.2, and since then Multimodal Models (Extended Generation 2) shards 1 and 4 fail in build 96024. The HF reference
SmolVLMModel.inputs_mergernow splits image features into blocks ofvision_config.patch_size(14) instead of the image token count (81 for SmolVLM2-2.2B), so the HF forward raisesshape '[-1, 14, 2048]' is invalid; vLLM's SmolVLM is not involved. The Qwen2-VL / Qwen2.5-VL failure in each shard is the next test starting while the failed HF model still holds GPU memory (27.4 of 32.5 GiB free vs 29.9 GiB needed), and the test after it gets the memory back. huggingface/transformers#49725 fixed it on Transformers main on Oct 19, after 5.20.2 was cut, so the bound can go when vLLM moves to a release that includes it.On MI355 with Transformers 5.20.2,
pytest models/multimodal/generation/test_common.pyon the two SmolVLM cases and the two Qwen cases that follow them in CI order: without the change the SmolVLM case fails the same way; with it, both SmolVLM cases skip and both Qwen cases pass in 12 runs. Five other runs failed only because another job on the shared node took up to 88 GB of the GPU.Not a duplicate: no open PR touches SmolVLM or this failure.
AI assistance (Claude Code) was used to draft this change. Every line was reviewed by the submitter.
Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.