Repository navigation
Conversation
Serve vllm-sr/d3-turbo on /v1/systemone, with request examples (text, one image, several images, a video), the offline LLM.classify flow, its limits and the measurements on AMD Instinct MI325X. Needs vllm-project#62584. Signed-off-by: Xunzhuo Liu <xunzhuo.liu@amd.com>
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
esmeetu
approved these changes
Oct 22, 2026
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add the recipe for
vllm-sr/d3-turbo, next to the six Decision 3.0 recipes inrecipes/models/vllm-sr/. It depends on #62584 (d3-turbo'sprefix_bidirattention), which is still a draft: this PR stays a draft until #62584 merges, after which every nightly includes the support the recipe describes.Claims
vllm serve vllm-sr/d3-turbowith no flags (pooling runner, up to 32,768 tokens per question, the checkpoint's validated length) and the opt-in Long context feature (--max-model-len 131072)./v1/systemoneexamples for a text state with several questions, one image, several images and a video, the output shape (one probability per option), and the offlineLLM.classifyflow with the state block size thatprefix_bidirneeds.meta.hardwarelists onlymi325x: verified; NVIDIA is not measured.Validation
node scripts/validate-source.mjs --source vllm --dir <this checkout>/recipesfrom vllm-project/recipes @8d3203a5:✓ vllm recipes ... are valid against the renderer(216 models);build-recipes-api.mjsrendersvllm-sr/d3-turbowithvllm serve vllm-sr/d3-turbo --tensor-parallel-size 1onmi325x, as for the other Decision 3.0 recipes.vllm/vllm-openai-rocm:nightly-rocm72-e68efc685ab1e6f1eda004ced7157e3ca411da2fand [Model] Support Decision 3.0 prefix_bidir attention (vllm-sr/d3-turbo) #62584's Python files onvllm-sr/d3-turbo@689b3af1(v1.1):vllm serve vllm-sr/d3-turboanswered its first request 270 s after launch with empty caches, the 52 GB download included;/v1/modelsreportsmax_model_len32768./v1/systemonerequests returned the answers shown in the guide; through the checkpoint's own runtime (AutoModel.from_pretrained(..., trust_remote_code=True), transformers 5.17.0) the same requests gave the same decisions, with a largest probability difference of 0.028.{'No / false': 0.00089, 'Yes / true': 0.99911};/v1/systemonegave 0.99911 for the same question.pre-commit run --files recipes/models/vllm-sr/d3-turbo.yaml: all hooks pass.Details
context_lengthis 131,072, the model card's long-context limit; the checkpoint's position limit is larger, and vLLM's default is the 32,768-token validated length ([Model] Support Decision 3.0 prefix_bidir attention (vllm-sr/d3-turbo) #62584 appliesdecision_config.json'svalidated_length)./v1/systemone, as the other Decision 3.0 recipes do.related_recipes.Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.