Repository navigation
[CI] Shard (H200 MIG 35GB / MI355 DPX) Multimodal Models (Standard) 4 automatically - #62562
Merged
khluu merged 1 commit intoOct 20, 2026
Conversation
… automatically Run the Whisper command as plain pytest from the step's working directory, so the planner can shard the step, and turn on automatic_shard for the step and its AMD mirror. The `cd ..` dates from when a spawned test process could only import `tests.*` from the repo root. spawn_new_process_for_each_test now puts the repo root on PYTHONPATH itself, and test_whisper.py sets VLLM_WORKER_MULTIPROC_METHOD=spawn in an autouse fixture. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thang Nguyen <thangnguyenvn647@gmail.com>
Contributor
Author
|
/ci run |
|
✅ Triggered Buildkite CI #96011 for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Multimodal Models (Standard) 4 runs as one long job because one of its commands, Whisper, starts with
cd .. &&, and automatic sharding only plans steps whose test commands are plainpytest. This PR makes that command plainpytestand turns onautomatic_shardfor the step and its AMD mirror. It replaces the hand split in #57065.Claims
pytest -v -s models/multimodal/generation/test_whisper.py -m core_modelcd ..andVLLM_WORKER_MULTIPROC_METHOD=spawnare no longer needed:cd ..dates from [CI/Build] Reorganize models tests #17459, when a spawned test process could only importtests.*from the repo root.spawn_new_process_for_each_testnow puts the repo root onPYTHONPATHitself ([CI] Add tests for cudagraph #27391), andtest_common.pyalready runs spawned tests fromtests/in Standard 1–3.test_whisper.pysetsVLLM_WORKER_MULTIPROC_METHOD=spawnin an autouse fixture ([CI] Whisper logprobs tests #30504).multi-modal-models-standard-4-other-whispertest_vit_cudagraph.pysplit by test)amd-multi-modal-models-standard-4-other-whisper(mirror)Validation
runtime_shard.plan_step, using main's timings on each step's own queue.pytest -p ci_otelwrapper. Every test ran in exactly one shard, with the same env./ci runchecks the real question: whether Whisper passes withoutcd ..on both lanes.Details
cd ..instead of moving Whisper to its own step. If the build shows the old import failure, the fallback is a separate Whisper step withworking_dir: /vllm-workspace.Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.
🤖 Generated with Claude Code