Repository navigation
Conversation
A shared-prefix junction is now a tuple of positions on the request,
produced by one helper, junction_boundaries(). When a dropping EAGLE group
takes part in the lookup, a junction J implies {J - A, J}: a sibling that
diverges within the group's drop unit past J resumes one alignment unit
lower, a sibling that diverges further resumes at J.
Consumers: SWA and Mamba retention masks, Mamba junction checkpoints,
scheduler chunk stops (one per position) and OffloadingConnector
reachable boundaries.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Yifan Qiao <yifanqiao@inferact.ai>
The MooncakeStore lookup becomes a junction source: the store coordinator computes junctions from per-group store hits with junction_boundaries(), and they travel back with the lookup result. The scheduler merges them into the request's junctions before compute, and store_mask adds them to the reachable boundaries through the request tracker. Sparse retention then keeps shared prefixes reusable through the store, without dense store retention. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yifan Qiao <yifanqiao@inferact.ai>
6 tasks done
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Stacked on #62278; review only the last commit. The MooncakeStore lookup now detects shared-prefix junctions, and the store keeps the SWA tails at those junctions under sparse retention. Without this, a fresh instance (or one that evicted the prefix locally) gets 0 hits from the store for siblings that share a prefix, because store retention keeps only each request's own replay tails.
Claims
Validation
End to end (GB200, 4 GPUs, base 83c9a54): the same serve command as #62278, plus
--kv-transfer-config '{"kv_connector":"MooncakeStoreConnector","kv_role":"kv_both"}'. Before every request after the first, the client calls/reset_prefix_cache, so all hits come from the store.external_prefix_cache_hits / queries)Unit tests (CPU): the store coordinator, scheduler, worker and connector suites, plus the core suites from #62278:
1562 passed. The new tests cover a two-instance save → lookup → save → lookup flow on one store, junctions instore_mask(several positions, never on Mamba groups), the tracker hand-off when a loading sibling skips its first save, and the lookup-response round trip, including payloads from writers that predate junction entries.Details
Source.
MooncakeStoreWorker.lookup()already queries the store hits per group. The store coordinator now also returns the longest single-group hit, and computes the junctions with the samejunction_boundaries()as the local coordinator. The lookup response carries them as 8-byte entries with a sentinel group id. Old readers ignore those entries, because the loader reads only real group ids.Consumer. The scheduler merges the store junctions into
request.shared_prefix_boundariesat lookup, before compute. So GPU retention, Mamba chunk stops and this request's own store saves all use them.RequestTrackerandReqMetacarry the junctions tostore_mask, which adds them to the reachable boundaries.Lifetime. Blocks are pinned when the save job is created, in the same
schedule()pass. The worker skips null block ids, so a tail block that the GPU already freed is not saved with wrong data.Conflict. #62255 moves the Mooncake metadata and wire structs to new modules; one of the two will need a rebase.
Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR. Claude Code wrote and verified the change and ran the GPU checks; a Kimi Code agent fleet reviewed the design and wrote test extensions; Codex reviewed the diff.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.
🤖 Generated with Claude Code