Repository navigation
[CI][AMD] Move the remaining legacy-only AMD groups into test_areas and regenerate test-amd.yaml - #62233
Draft
AndreasKaratzas wants to merge 2 commits into
Draft
[CI][AMD] Move the remaining legacy-only AMD groups into test_areas and regenerate test-amd.yaml#62233AndreasKaratzas wants to merge 2 commits into
AndreasKaratzas wants to merge 2 commits into
Conversation
…nd regenerate test-amd.yaml Add test_areas steps for the AMD coverage only test-amd.yaml had, sync the drifted MI300 mirrors, add a gating MI355 Elastic EP mirror, and regenerate test-amd.yaml as a copy of the test_areas AMD steps with every step optional. Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Andreas Karatzas <akaratza@amd.com>
…r AMD GPU Attention, MoE and Quantization Kernels, Quantization, Language Models (PPL), CUDAGraph and V1 Spec Decode already run in test_areas on MI300 or MI250, and the MI355 Kimi K3 mirror runs the files the MI300 Kimi K3 job did. The spatial-merge vision test already runs in the CPU job. Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kernels.yaml: MI300 MoE Kernels Multi-GPU, and the AITERtest_modular_kernel_combinationsrun in the MI300 MoE Kernels mirror ([ROCm][MoE] Split AiterExperts by weight-quantization key #60322 added both totest-amd.yamlonly).models_basic.yaml: MI355 Kimi K3 Multi-GPU; its tests skip on the 1-GPU MI355 Kimi K3 mirror.expert_parallelism.yaml: a gating MI355 mirror for Elastic EP Scaling, which only had a legacy MI300 job.models_distributed.yaml,quantization.yaml: the 2-GPU vision test on MI300 Distributed Models shard 2, and torchao 0.18.0 for the MI300 Quantization mirror ([Core] Update PyTorch to 2.14.0, torchvision to 0.29.0, triton to 3.8.0 (release channel) #52183 bumped NVIDIA andtest-amd.yamlonly).test-amd.yaml: regenerated as a copy of the test_areas AMD steps, with every step stilloptional.test-amd.yamland the test_areas mirrors have drifted apart. This PR moves into test_areas only the AMD coverage that test_areas doesn't already run on some AMD GPU, so no suite gets a second AMD platform. The regenerated file drops 84 legacy groups whose tests run in test_areas under a newer label or on another AMD GPU, including the five MRV2 groups #54823 removed. It also drops the gfx950 copies of Attention, MoE and Quantization Kernels, Quantization, Language Models (PPL), CUDAGraph and V1 Spec Decode, which run on MI300 or MI250 in test_areas (#57599 kept Quantization off MI355 on purpose), and gains 68 steps main CI runs but the legacy file never had. Rendered through both ci-infra generators, all 236 AMD jobs match on queue, commands, environment, timeout and shard count; main CI gains exactly the 3 new AMD steps and only the 3 edited steps change.The added steps are copies of legacy jobs that passed every recent
amd-cimain nightly they ran in (MoE Kernels Multi-GPU 8/8, Kimi K3 Multi-GPU 28/28, Elastic EP on MI300 28/28). On MI355 (gfx950), Kimi K3 Multi-GPU passed 10/10 and Elastic EP 14 of 16 (the other 2 failed when another process took the GPU memory). MI300 hardware wasn't available locally. #59677 makes the torchao and MI300 MoE changes too; whichever lands second drops them.AI assistance (Claude Code) was used to draft this change. Every line was reviewed by the submitter.
Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.