Repository navigation
Conversation
.dockerignore drops tracked paths (/recipes since #61302), so setuptools-scm sees a dirty tree in the wheel build and appends .dYYYYMMDD, while the Rust frontend build already pins dirty=false. Apply the same pin to the wheel. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: khluu <khluu000@gmail.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Member
Author
|
/ci run |
|
✅ Triggered Buildkite CI #95618 for commit |
6 tasks done
Member
|
Close in favor of #62221 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix the Rust frontend version mismatch that fails
:nvidia: (H200 MIG 18GB) Rust Frontend OpenAI CoverageandServe/Admin Coverageon main (since 95599).test_uds.py::test_show_versionassertsrust_frontend_version == VLLM_VERSION, but the Python wheel is stamped...+g<sha>.d20261017while the Rust frontend is not.Root cause: #61302 added
/recipesto.dockerignore. Those files are tracked, so in the Docker build context setuptools-scm sees them as deleted, marks the tree dirty, and appends.dYYYYMMDDto the wheel version. Therust-buildstage already setsSETUPTOOLS_SCM_PRETEND_METADATA="{dirty=false}"; the wheel build did not.Fix: apply
dirty=falseto the wheel build unconditionally, so both stamps derive from the same metadata. A regression test intests/tools/test_docker_build_metadata_args.pychecks the wheel build sets it.Not a duplicate: this supersedes #53719 (same author), which applied the pin only for
PYTORCH_NIGHTLY=1builds; this version also covers the nightly case. I'll close #53719 once this lands.Test Plan
origin/main.Notes
AI assistance (Claude Code) was used; reviewed by the submitter.
🤖 Generated with Claude Code