Repository navigation
[CI] Shard E2E Scheduling, Benchmarks CLI and six AMD mirrors automatically - #62039
Merged
khluu merged 1 commit intoOct 20, 2026
Merged
Conversation
…ically Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thang Nguyen <thangnguyenvn647@gmail.com>
Contributor
Author
|
/ci run |
|
✅ Triggered Buildkite CI #95430 for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Turns on
automatic_shardfor two long NVIDIA steps and six AMD mirrors that run longer than 20 minutes as one job. Picked by p90 duration over the last day on main. Only the flag changes; no commands or tests change.Claims
e2e-scheduling-1-gpupytestfile, split by testamd-e2e-scheduling-1-gpu(mirror)benchmarks-cli-testpytestoverbenchmarks/amd-kernels-root-misc-test-b200(mirror)pytestover a list of kernel test files, with--deselectamd-spec-decode-eagle-nightly-b200(optional mirror)pytestover a directory; its large file is split by testamd-spec-decode-speculators-mtp-nightly-b200(optional mirror)pytestcommands over directoriesamd-lm-eval-large-models-ep-2xb200(optional mirror)exportsetup, thenpyteston the gsm8k eval with--config-list-file, split by testamd-lm-eval-large-models-4xh100(optional mirror)exportsetup, thenpyteston the lm-eval harness test with--config-list-fileand--tp-size, split by testkernels-root-misc-test-b200,spec-decode-eagle-nightly-b200andspec-decode-speculators-mtp-nightly-b200are enrolled so their mirrors can shard (a mirror shards only when its base step is enrolled). Their own runs plan to one shard, so they stay one job.Validation
runtime_shard.plan_step, using main's timings on the step's own queue.pytest -p ci_otelwrapper. Every test ran in exactly one shard, with the same env. The three single-shard base steps were confirmed to stay one job./ci runexercises E2E Scheduling, Benchmarks CLI and the E2E Scheduling and Miscellaneous Kernels mirrors. The four optional mirrors need a build scoped to their keys.Details
amd-lm-eval-large-models-ep-2xb200's planner output is marked over budget: one eval test takes most of 20 minutes by itself, so its slowest shard sits near the target.language-models-test-extended-generationand its mirror: each job first builds mamba-ssm and causal-conv1d from source, which every shard would repeat. They wait for [CI] Prebuild mamba-ssm and causal-conv1d in the CUDA test image for (H200) Language Models (Hybrid), (L4) Granite and Extended Generation #58795, which prebuilds both in the test image.entrypoints-integration-api-server-generate's mirror: two of its files assert oncaplog, the pattern that tookentrypoints-integration-multimodalout of sharding.benchmarks-cli-test's mirror runs under 20 minutes, so it stays one job.automatic_shard: truelines in.buildkite/test_areas/{engine,benchmarks,kernels,spec_decode,lm_eval}.yaml.Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.
🤖 Generated with Claude Code