Repository navigation
[Feature][DSv4.1][NIXL] Enable PCP Prefill with NIXL P/D - #61746
Draft
wangyicong52 wants to merge 2 commits into
Draft
wangyicong52 wants to merge 2 commits into
wangyicong52 wants to merge 2 commits into
Conversation
Contributor
|
Documentation preview: https://vllm--61746.org.readthedocs.build/en/61746/ |
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
wangyicong52
force-pushed
the
feat/dsv41-pcp-nixl
branch
from
October 16, 2026 06:29
a888e22 to
af96945
Compare
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
wangyicong52
force-pushed
the
feat/dsv41-pcp-nixl
branch
from
October 21, 2026 06:50
af96945 to
192c4c9
Compare
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
wangyicong52
force-pushed
the
feat/dsv41-pcp-nixl
branch
from
October 25, 2026 03:14
192c4c9 to
c1dec9a
Compare
wangyicong52
force-pushed
the
feat/dsv41-pcp-nixl
branch
from
October 25, 2026 03:26
c1dec9a to
4b4952c
Compare
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
wangyicong52
force-pushed
the
feat/dsv41-pcp-nixl
branch
from
October 28, 2026 08:21
4b4952c to
b963b86
Compare
…ucer ranks vllm-project#53903 made replicated-PCP producer ranks > 0 report every request they were asked to send as done, so that the world_size aggregation in KVOutputAggregator completes, and removed the code that hid those completions from get_finished(). vllm-project#53781 then added NixlBaseConnector.get_transfer_results(), which the model runner now calls instead of get_finished(), with the old clear() for those ranks carried over. The synthetic completions were dropped again, the aggregator waited for pcp_size reports and received one, and the prefill side never freed a finished request's blocks. Return the worker's results unchanged, as get_finished() does. Update the handshake test that asserted the empty set, and add an aggregator test for a PCP=2 replicated producer. Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Sohom Chakraborty <16609933+sohom-cs@users.noreply.github.com> (cherry picked from commit 87e86bf)
wangyicong52
force-pushed
the
feat/dsv41-pcp-nixl
branch
from
October 28, 2026 08:53
b963b86 to
a6f5c5f
Compare
Allow GPU NixlConnector pull producers to use DeepSeek-V4.1 PCP, including fixed-length DSpark and APC with SWA bounded replay. Retain PP=DP=DCP=1, synchronous scheduling and the existing backend, consumer-PCP, push, bidirectional and custom-connector restrictions. Build on merged vllm-project#59857 and vllm-project#61994 plus the replicated-PCP completion fix from vllm-project#59325. Keep the capability policy and tests model-local. The vllm-project#59330 handoff stack is intentionally excluded; this change does not repair the ordinary SWA P/D N/N-1 boundary. Current-head GPU, uncapped quality and performance validation remain pending. Co-authored-by: OpenAI Codex <noreply@openai.com> Signed-off-by: wangyicong <wangyicong@bytedance.com>
wangyicong52
force-pushed
the
feat/dsv41-pcp-nixl
branch
from
October 28, 2026 09:00
a6f5c5f to
20a8826
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Follow-up to #59857, enabling text-only DeepSeek-V4.1-Flash PCP Prefill with NIXL P/D. Stacked on #59325 for replicated-PCP producer completion.
Claims
NixlConnectorpull producers to use PCP, with PCP=1 on Decode.Validation
Image
vllm/vllm-openai:nightly-edad8b03c5285a1c12e7e4f83c1af709b319a01bOfficial linux/amd64 digest:
sha256:d31ecffc8a9613b1f7c6c849a45e01bb9f0ac86a177f7dd802f29b4e51390198.Software
20a882654abbb8aee6ebef1ba110a76314d8a164(vllm/models/deepseek_v41/nvidia/model.py).52c8468f7c27a73047460376b5f90fcb13af8695(vllm/distributed/kv_transfer/kv_connector/v1/nixl/connector.py).vLLM startup
Relevant environment:
Prefill (TP2/PCP4):
Decode (TP8/PCP1):
GSM8K
EvalScope version:
1.11.1.1283 / 1319correct (97.2707%), within the local historical control range of1279-1286 / 1319.1319 / 1319requests succeeded with0API errors;3responses reached the 8192-token limit.10,552successful rank transfers and53,282,008,576transferred bytes, with0failed transfers, notification failures, or KV expirations.0preemptions and0service restarts.Details
Keep the capability checks in the NVIDIA model and reuse the existing cache-transfer path. Add one focused PCP+NIXL configuration test. The completion fix is inherited from #59325.
AI assistance was used for implementation and tests.
Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.