Skip to content

[Benchmark] Remove the temporary bench forward dummy loader - #61676

Merged
WoosukKwon merged 3 commits into
mainfrom
woosuk/forward-bench-cleanup
Oct 14, 2026
Merged

WoosukKwon merged 3 commits into
mainfrom
woosuk/forward-bench-cleanup

Conversation

@WoosukKwon

@WoosukKwon WoosukKwon commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator

Overview

Follow-up to #61339 (vllm bench forward): remove its temporary dummy loader, now that #60096 has landed, and add ROCm TODOs.

Claims

  • The bench's forward_bench_dummy loader is gone; --load-format dummy uses the stock DummyModelLoader. It ran an early process_weights_after_loading() so dummy-loaded DeepSeek-V4.1 could fuse its MegaMoE shared experts. [Model][MoE] Load MegaMoE experts directly into the DeepGEMM layout #60096 loads MegaMoE experts directly into the DeepGEMM layout, so the CUDA models no longer have finalize_mega_moe_weights and the workaround was already a no-op.
  • No timing change on DeepSeek-V4.1 (below).
  • The model-microbenchmark skill drops its caveat about degenerate dummy norm weights, fixed by [Model Loader] Keep norm layers neutral under dummy weight init #61323.
  • TODOs mark where ROCm support is missing (the bench is CUDA-only for now; its end-to-end test is skipped on ROCm because it hangs there, likely on the in-graph timing events).

Validation

pytest tests/benchmarks/test_forward_cli.py   # 3 passed (GB200)

DeepSeek-V4.1-Flash, DEP4 on one GB200 node, MegaMoE, FlashInfer sparse MLA, fp8 KV, ~100K KV, balanced routing; same environment and node, main's loader vs this PR:

case main this PR diff
decode, 32 reqs 15565 us 15635 us +0.45%
decode, 128 reqs 19986 us 20011 us +0.12%
prefill 16K 205.1 ms 201.9 ms -1.57%
prefill 8 x 1K 131.5 ms 129.7 ms -1.32%

Diffs are within run-to-run noise (sample spread up to ~1% on V4.1 DEP). Graph-vs-eager and replay checks match between the two.

Details


Pull Request Checklist
  • I used vLLM's /pr-checklist skill. (Mandatory for agents, optional for humans).

  • AI assistance was used during the creation of this PR.

  • Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.

  • Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.

  • Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.

  • Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.

Not a duplicate: open PRs were searched for bench forward and the loader's name; none touch it.

AI assistance (Claude Code) was used to write this change and to run the tests and validation above.

🤖 Generated with Claude Code

WoosukKwon and others added 2 commits October 14, 2026 18:18
#60096 loads MegaMoE experts directly into the DeepGEMM layout, so dummy
loading no longer needs an early finalize. Also drop the skill's caveat
about dummy norm weights, fixed by #61323.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
The bench is CUDA-only for now but should support ROCm once its hang
there (likely the in-graph timing events) is fixed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@mergify mergify Bot added performance Performance-related issues agents Related to information for agents labels Oct 14, 2026
@WoosukKwon

Copy link
Copy Markdown
Collaborator Author

/ci run

@github-actions

Copy link
Copy Markdown

✅ Triggered Buildkite CI #94895 for commit 20d988f7d52a.

@WoosukKwon
WoosukKwon merged commit 2e8a593 into main Oct 14, 2026
90 of 91 checks passed
@WoosukKwon
WoosukKwon deleted the woosuk/forward-bench-cleanup branch October 14, 2026 20:30
AndreasKaratzas pushed a commit to AndreasKaratzas/vllm that referenced this pull request Oct 16, 2026
…ject#61676)

Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Signed-off-by: Andreas Karatzas <AndreasKaratzas@users.noreply.github.com>
michael-gpu pushed a commit to practical-inference/vllm-ampere-extended that referenced this pull request Oct 20, 2026
…ject#61676)

Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agents Related to information for agents performance Performance-related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant