Repository navigation
[Benchmark] Remove the temporary bench forward dummy loader - #61676
Merged
Merged
Conversation
The bench is CUDA-only for now but should support ROCm once its hang there (likely the in-graph timing events) is fixed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Collaborator
Author
|
/ci run |
|
✅ Triggered Buildkite CI #94895 for commit |
6 tasks done
AndreasKaratzas
pushed a commit
to AndreasKaratzas/vllm
that referenced
this pull request
Oct 16, 2026
…ject#61676) Signed-off-by: Woosuk Kwon <woosuk@inferact.ai> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Andreas Karatzas <AndreasKaratzas@users.noreply.github.com>
michael-gpu
pushed a commit
to practical-inference/vllm-ampere-extended
that referenced
this pull request
Oct 20, 2026
…ject#61676) Signed-off-by: Woosuk Kwon <woosuk@inferact.ai> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Follow-up to #61339 (
vllm bench forward): remove its temporary dummy loader, now that #60096 has landed, and add ROCm TODOs.Claims
forward_bench_dummyloader is gone;--load-format dummyuses the stockDummyModelLoader. It ran an earlyprocess_weights_after_loading()so dummy-loaded DeepSeek-V4.1 could fuse its MegaMoE shared experts. [Model][MoE] Load MegaMoE experts directly into the DeepGEMM layout #60096 loads MegaMoE experts directly into the DeepGEMM layout, so the CUDA models no longer havefinalize_mega_moe_weightsand the workaround was already a no-op.Validation
DeepSeek-V4.1-Flash, DEP4 on one GB200 node, MegaMoE, FlashInfer sparse MLA, fp8 KV, ~100K KV, balanced routing; same environment and node, main's loader vs this PR:
Diffs are within run-to-run noise (sample spread up to ~1% on V4.1 DEP). Graph-vs-eager and replay checks match between the two.
Details
Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.
Not a duplicate: open PRs were searched for
bench forwardand the loader's name; none touch it.AI assistance (Claude Code) was used to write this change and to run the tests and validation above.
🤖 Generated with Claude Code