Skip to content

Review/umbp test split preview - #61351

Closed
charxwu wants to merge 12 commits into
vllm-project:mainfrom
charxwu:review/umbp-test-split-preview
Closed

charxwu wants to merge 12 commits into
vllm-project:mainfrom
charxwu:review/umbp-test-split-preview

Conversation

@charxwu

@charxwu charxwu commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Overview

Claims

Validation

Details


Pull Request Checklist
  • I used vLLM's /pr-checklist skill. (Mandatory for agents, optional for humans).

  • AI assistance was used during the creation of this PR.

  • Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.

  • Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.

  • Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.

  • Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.

charxwu and others added 12 commits October 12, 2026 16:13
Introduce the runtime-neutral object model, connector facade, scheduler and worker lifecycle, transfer metadata, block ownership, and runtime adapter contracts.

Signed-off-by: CharlesWu <Charles.Wu@amd.com>
Co-authored-by: Yichao Zhu <Yichao.Zhu@amd.com>
Cover object identity, layout planning, scheduler and worker lifecycle, metadata serialization, load and store planning, request tracking, and store barriers with the reusable in-memory runtime.

Co-authored-by: Yichao Zhu <Yichao.Zhu@amd.com>
Add compact whole-block planning, transfer cancellation contracts, asynchronous lookup, hybrid and Mamba coordination, partial hash hits, KV events, metrics, and the post-review event correctness fixes.

Signed-off-by: CharlesWu <Charles.Wu@amd.com>
Co-authored-by: Yichao Zhu <Yichao.Zhu@amd.com>
Add focused coverage for asynchronous lookup lifecycle, multi-group and Mamba coordination, partial hash hits, worker-quorum KV events, failed object reporting, and transfer statistics.

Signed-off-by: CharlesWu <Charles.Wu@amd.com>
Co-authored-by: Yichao Zhu <Yichao.Zhu@amd.com>
Add the embedded MORI adapter, GPU buffer registration, bulk and ranged transfers, timeout and cancellation handling, eviction retry and reporting, lookup sockets, and DRAM configuration.

Signed-off-by: CharlesWu <Charles.Wu@amd.com>
Co-authored-by: Yichao Zhu <Yichao.Zhu@amd.com>
Add embedded runtime contract tests, MORI GPU integration, token-level restore coverage, reusable test helpers, user documentation, and AMD CI wiring.

Signed-off-by: CharlesWu <Charles.Wu@amd.com>
Co-authored-by: Yichao Zhu <Yichao.Zhu@amd.com>
Add the external node-local UMBP server adapter, endpoint and startup validation, shared-pool failure behavior, DP-aware embedded endpoint isolation, and synchronized blocked-store handling.

Signed-off-by: CharlesWu <Charles.Wu@amd.com>
Co-authored-by: Yichao Zhu <Yichao.Zhu@amd.com>
Cover standalone configuration, cross-engine sharing, server failure behavior, blocked-store synchronization, and real multi-GPU server transfers.

Signed-off-by: CharlesWu <Charles.Wu@amd.com>
Co-authored-by: Yichao Zhu <Yichao.Zhu@amd.com>
Select reusable prefix blocks from the GPU free queue, close full-attention prefix chains, recheck authoritative residency, and retry transient lookup failures without crashing the scheduler.

Signed-off-by: CharlesWu <Charles.Wu@amd.com>
Add lazy free-queue unit coverage and validate eager and lazy token-level MORI restore with a bounded GPU memory budget.

Signed-off-by: CharlesWu <Charles.Wu@amd.com>
Record the shared-base and runtime split, commit ordering, validation gates, and merge decisions used for the combined UMBP series.

Signed-off-by: CharlesWu <Charles.Wu@amd.com>
Document the direct-node MI355X validation environment and the passing embedded, standalone, eager, and lazy MORI test coverage.

Signed-off-by: CharlesWu <Charles.Wu@amd.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@mergify

mergify Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Documentation preview: https://vllm--61351.org.readthedocs.build/en/61351/

@mergify mergify Bot added documentation Improvements or additions to documentation ci/build kv-connector labels Oct 13, 2026
@charxwu charxwu closed this Oct 13, 2026
@github-actions

Copy link
Copy Markdown

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

PRs do not trigger a full CI run by default. Reviewers with write access and configured trusted contributors can comment /ci run for upstream CI or /amd-ci run for AMD CI only whenever CI signals are needed.

Once the PR is approved or has the ready label, the PR author can also use the corresponding /ci run, /ci retry, and /ci cancel commands, or their /amd-ci variants. New commits do not start upstream CI automatically.

If you have any questions, please reach out to us on Slack at https://slack.vllm.ai.

Agent Guidelines

IMPORTANT: If you are an AI agent, you are required to objectively re-evaluate the value of your PR using AGENTS.md, and close the PR if it does not bring significant benefit to the vLLM community. Failure to do so may result in an immediate ban.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build documentation Improvements or additions to documentation kv-connector

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant