Repository navigation
Conversation
Reuse the existing coefficient stream path with an explicit Hopper opt-in. Keep SM90 out of the SM100 collective fusion and add dispatch coverage. GPU correctness and performance validation remain pending. Co-authored-by: OpenAI Codex <noreply@openai.com> Signed-off-by: ahmed xijiaat <52128022+xijiaat@users.noreply.github.com>
5 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Draft: add an experimental, explicit opt-in for DeepSeek-V4.1 mHC coefficient overlap on Hopper (SM90), reusing the stream path introduced by #57603. Hopper remains disabled by default; GPU validation is pending.
Claims
KernelConfig.enable_mhc_overlap=Nonepreserves SM100 automatic selection;Trueadditionally permits SM90, andFalsedisables overlap.Validation
CPU only, using this branch's Python source on Linux, Python 3.12.3 and pytest 9.1.1, in an isolated container with no GPU devices (2 CPU cores / 4 GiB). Installed dependencies were inherited from a vLLM v0.28.0 image; this was not a fresh main wheel build.
CUDA_VISIBLE_DEVICES= NVIDIA_VISIBLE_DEVICES=void VLLM_TARGET_DEVICE=cpu \ PYTHONPATH=$PWD PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 \ .venv/bin/python -m pytest --confcutdir=tests/kernels/mhc -o addopts= \ -q tests/kernels/mhc/test_mhc_dispatch.py14 passed, covering opt-in/default/off selection, unsupported architectures, missing DeepGEMM, shape/ubatching fallback and exclusion of the SM100 collective. These mock capability checks validate dispatch only. Source-only version metadata and torch deprecation warnings were emitted.
All applicable hooks pass, including mypy, config validation and Buildkite test tethering. The new dispatch tests are in the existing mHC suite. The replay test now permits SM90 but has not been run on GPU; the existing dedicated NVIDIA mHC CI job uses B200.
Before marking ready:
VLLM_GPU_SYNC_CHECK=error.Details
The existing eligibility gate excludes SM90. This change makes Hopper experimental and opt-in via
--kernel-config '{"enable_mhc_overlap": true}'; omitting it preserves defaults. This is a proposed serving configuration, not a GPU-validated launch recipe. The existing configuration hash includes the new field.This reuses vLLM's TF32 prenorm coefficient path. It does not port the compensated-BF16 projection from sgl-project/sglang#41251. Kernel arithmetic, the existing stream schedule and the GB200-derived 16-token threshold are unchanged. The all-reduce architecture guard is needed because its caller can now also create an mHC stream on SM90.
Duplicate-work checks on 2026-10-09 covered issue #57448 and open/closed PRs matching mHC, overlap, SM90 and Hopper. No equivalent Hopper coefficient-overlap PR was found: #57603 targets SM100; #59802 targets ROCm; #59129 packages the separate DeepGEMM correctness repair. This draft depends on confirming that repair rather than duplicating it.
AI assistance (OpenAI Codex) was used for investigation, implementation, tests and this description. This is WIP awaiting GPU resources; model evaluations and performance results are not yet available.
Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.