Repository navigation
[Feature][Frontend] Control the log level of request JSON body using env var - #60630
Merged
benchislett merged 6 commits intoOct 15, 2026
Merged
Conversation
Signed-off-by: talora <talora@nvidia.com>
talorabr
requested review from
AndreasKaratzas,
DarkLight1337,
NickLucche,
aarnphm,
njhill and
robertgshaw2-redhat
as code owners
October 8, 2026 12:54
talorabr
marked this pull request as draft
October 8, 2026 13:28
…iable Signed-off-by: talora <talora@nvidia.com>
talorabr
marked this pull request as ready for review
October 8, 2026 15:39
benchislett
approved these changes
Oct 14, 2026
Member
|
/ci run |
benchislett
enabled auto-merge (squash)
October 14, 2026 21:45
|
✅ @talorabr, CI is now available for this PR.
|
|
✅ Triggered Buildkite CI #94945 for commit |
Contributor
Author
|
/ci retry |
|
✅ Queued 1 failed job(s) for retry in Buildkite CI #94945. |
Contributor
Author
|
/ci retry |
|
✅ Buildkite CI #94945 failed during CI setup, so its test failure set is incomplete. Use |
Contributor
Author
|
/ci run |
|
✅ Triggered Buildkite CI #95097 for commit ℹ️ This PR is 3 commits behind upstream |
Member
5 tasks done
6 tasks done
This was referenced Oct 18, 2026
michael-gpu
pushed a commit
to practical-inference/vllm-ampere-extended
that referenced
this pull request
Oct 20, 2026
…env var (vllm-project#60630) Signed-off-by: talora <talora@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds an option to change the log level used for logging the request body JSON.
This PR is related to the previously merged PR: #58163
Claims
--enable-log-requestsis set.VLLM_REQUEST_BODY_LOG_LEVEL=INFOwith--enable-log-requestsmakes all requests' JSON body will be logged in INFO log level.VLLM_REQUEST_BODY_LOG_LEVEL=NONEXISTwill show a warning to the user that this log level does not exist, and request body logging will be skipped.Validation
In all validations I sent the following request to the server:
Default behavior is not changed
Server command -
vllm serve --model meta-llama/Llama-3.2-1B-Instruct --host 0.0.0.0 --trust-remote-code --dtype auto --gpu-memory-utilization 0.40 --enforce-eagerLog -
Server command -
vllm serve --model meta-llama/Llama-3.2-1B-Instruct --host 0.0.0.0 --trust-remote-code --dtype auto --gpu-memory-utilization 0.40 --enforce-eager --enable-log-requestsLog -
Server command -
VLLM_LOGGING_LEVEL=DEBUG vllm serve --model meta-llama/Llama-3.2-1B-Instruct --host 0.0.0.0 --trust-remote-code --dtype auto --gpu-memory-utilization 0.40 --enforce-eager --enable-log-requestsLog -
Setting
VLLM_REQUEST_BODY_LOG_LEVEL=INFOwith--enable-log-requestsServer command -
VLLM_REQUEST_BODY_LOG_LEVEL=INFO vllm serve --model meta-llama/Llama-3.2-1B-Instruct --host 0.0.0.0 --trust-remote-code --dtype auto --gpu-memory-utilization 0.40 --enforce-eager --enable-log-requestsLog -
Setting
VLLM_REQUEST_BODY_LOG_LEVEL=NONEXISTwill show a warningServer command -
VLLM_REQUEST_BODY_LOG_LEVEL=NONEXIST vllm serve --model meta-llama/Llama-3.2-1B-Instruct --host 0.0.0.0 --trust-remote-code --dtype auto --gpu-memory-utilization 0.40 --enforce-eager --enable-log-requestsLog -
Details
Motivation: Previously, logging just the request JSON body would require turning on the DEBUG log, which can be very heavy. In some cases, like running agentic benchmarks, we want to gather the requests for an option to replay these requests.
Design decisions:
The user can choose the log level for the request JSON body logging using an environment variable, while maintaining backward compatibility with the DEBUG log that was the behavior before.
Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.