Repository navigation
[CI] Fix failing test_deepseek_v4_rocm_dspark* tests - #60462
Conversation
Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com>
Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com>
|
/ci run |
|
❌ This PR is 3 commits behind upstream |
|
/ci run |
|
✅ Triggered Buildkite CI #93393 for commit |
CI selector (shadow): 10 test steps (24 jobs) instead of 11 (27 jobs)Shadow mode: this changes nothing about what CI runs. It shows what the evidence-based selector would pick for this PR, next to today's rules. How it works. Feedback welcome: reply here if it would skip a step this change needs, or runs something unrelated.
Selector would run (10)
Would skip (today's rules run them) (1)
Would add (today's rules do not run them) (0)none AMD mirrors: would skip (1)
AMD mirrors: would add (0)none 2 changed files · base |
Overview
(MI355) Basic Modelsgroup is failing on main like this https://buildkite.com/vllm/ci/builds/93367/canvas?jid=01a11794-4f57-4b94-b28f-6504d960216d&tab=output or https://buildkite.com/vllm/ci/builds/93368/list?sid=01a1175c-5802-4544-97b8-58c6b1cd455f&tab=output.Likely appeared after #59685 where the mtp model now accesses
self.model.layers, so the tests need to mock it.The test was not dependent on the model source file being changed so hence the test was not run on the above PR. I add it here as a dependency.
Claims
Validation
Details
Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.