Skip to content

[CI] Fix failing test_deepseek_v4_rocm_dspark* tests - #60462

Merged
khluu merged 3 commits into
vllm-project:mainfrom
simondanielsson:fix/dspark-loader-test-stub
Oct 7, 2026
Merged

khluu merged 3 commits into
vllm-project:mainfrom
simondanielsson:fix/dspark-loader-test-stub

Conversation

@simondanielsson

@simondanielsson simondanielsson commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Overview

(MI355) Basic Models group is failing on main like this https://buildkite.com/vllm/ci/builds/93367/canvas?jid=01a11794-4f57-4b94-b28f-6504d960216d&tab=output or https://buildkite.com/vllm/ci/builds/93368/list?sid=01a1175c-5802-4544-97b8-58c6b1cd455f&tab=output.

Likely appeared after #59685 where the mtp model now accesses self.model.layers, so the tests need to mock it.

The test was not dependent on the model source file being changed so hence the test was not run on the above PR. I add it here as a dependency.

Claims

Validation

Details


Pull Request Checklist
  • I used vLLM's /pr-checklist skill. (Mandatory for agents, optional for humans).

  • AI assistance was used during the creation of this PR.

  • Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.

  • Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.

  • Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.

  • Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.

Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@mergify mergify Bot added deepseek Related to DeepSeek models DSv4 rocm Related to AMD ROCm dflash labels Oct 7, 2026
Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com>
Comment thread .buildkite/test_areas/models_basic.yaml
@mergify mergify Bot added the ci/build label Oct 7, 2026

@micah-wil micah-wil left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@simondanielsson simondanielsson added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 7, 2026
@simondanielsson

Copy link
Copy Markdown
Contributor Author

/ci run

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

❌ This PR is 3 commits behind upstream main. Your branch must contain every commit currently on upstream main. No new CI build was started. Merge or rebase onto the latest main, then rerun /ci run. To test this branch at your own risk, use /ci run --allow-stale.

@simondanielsson

Copy link
Copy Markdown
Contributor Author

/ci run

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

✅ Triggered Buildkite CI #93393 for commit 3aceb5cc7d6d.

@AndreasKaratzas
AndreasKaratzas enabled auto-merge (squash) October 7, 2026 19:31
@vllm-agent

Copy link
Copy Markdown
Collaborator

CI selector (shadow): 10 test steps (24 jobs) instead of 11 (27 jobs)

Shadow mode: this changes nothing about what CI runs. It shows what the evidence-based selector would pick for this PR, next to today's rules. How it works.

Feedback welcome: reply here if it would skip a step this change needs, or runs something unrelated.

steps (jobs) Today's rules Selector Would skip Would add
NVIDIA, CPU and others 11 (27) 10 (24) 1 (3) 0 (0)
AMD mirrors 8 (23) 7 (20) 1 (3) 0 (0)
Selector would run (10)
  • basic-models-test-other-cpu
  • basic-models-tests-extra-initialization ×14
  • basic-models-tests-initialization
  • basic-models-tests-other
  • glm5next-unit-tests
  • inkling-unit-tests-b200
  • kimi-k3-prefix-cache-4xb200 ×2
  • kimi-k3-unit-tests-b200
  • qwen4-exp-unit-tests
  • qwen4-exp-unit-tests-cpu
Would skip (today's rules run them) (1)
  • distributed-model-tests-2-gpus ×3
Would add (today's rules do not run them) (0)

none

AMD mirrors: would skip (1)
  • distributed-model-tests-2-gpus ×3
AMD mirrors: would add (0)

none

2 changed files · base e572e02d21 · head 3aceb5cc7d · Python record: build 93039 at 1e5d0ea888 · kernel record: table 43b4aae (build 93244), map 43b4aae · not counted: 10 build steps, 5 A100 steps the generator no longer emits, 0 optional steps the selector would also run

@khluu
khluu disabled auto-merge October 7, 2026 21:18
@khluu
khluu merged commit 947dd62 into vllm-project:main Oct 7, 2026
39 of 40 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in AMD Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build deepseek Related to DeepSeek models dflash DSv4 ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants