Skip to content

[Perf][DSV4.1] Enable the fused all-reduce + mHC boundary at TP2 #60355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andakai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Perf][DSV4.1] Enable the fused all-reduce + mHC boundary at TP2 #60355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions tests/distributed/test_custom_all_reduce.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,10 +176,11 @@ def check(outputs):
@pytest.mark.skipif(
not current_platform.is_device_capability_family(100), reason="Requires SM100"
)
def test_all_reduce_mhc_matches_unfused_path(monkeypatch):
if torch.accelerator.device_count() < 4:
pytest.skip("Requires four GPUs with NVLink multicast")
multi_process_parallel(monkeypatch, 4, 1, _all_reduce_mhc)
@pytest.mark.parametrize("tp_size", [2, 4])
def test_all_reduce_mhc_matches_unfused_path(monkeypatch, tp_size):
if torch.accelerator.device_count() < tp_size:
pytest.skip(f"Requires {tp_size} GPUs")
multi_process_parallel(monkeypatch, tp_size, 1, _all_reduce_mhc)


@pytest.mark.parametrize(
Expand Down
4 changes: 3 additions & 1 deletion tests/kernels/mhc/test_mhc_kernels.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,9 @@
"tp,ep,hidden,hc,multicast,expected",
[
(4, False, 5120, 4, 1, True),
(2, False, 5120, 4, 1, False),
(2, False, 5120, 4, 1, True),
(1, False, 5120, 4, 1, False),
(8, False, 5120, 4, 1, False),
(4, True, 5120, 4, 1, False),
(4, False, 4096, 4, 1, False),
(4, False, 5120, 2, 1, False),
Expand Down
2 changes: 1 addition & 1 deletion vllm/models/deepseek_v41/nvidia/ops/mhc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def supports_mhc_all_reduce(vllm_config: VllmConfig) -> bool:
parallel = vllm_config.parallel_config
config = vllm_config.model_config.hf_config
if (
parallel.tensor_parallel_size != 4
parallel.tensor_parallel_size not in (2, 4)
or parallel.enable_expert_parallel
or config.hidden_size != 5120
or config.hc_mult != 4
Expand Down
Loading