Repository navigation
[Spec Decode] Rename AR speculators to StandaloneAR / TargetDependentAR - #60335
Merged
ywang96 merged 2 commits intoOct 7, 2026
Merged
Conversation
Signed-off-by: Giancarlo Delfin <gdelfin@inferact.ai>
TheEpicDolphin
marked this pull request as ready for review
October 7, 2026 02:38
TheEpicDolphin
requested review from
Harry-Chen,
WoosukKwon,
khluu,
njhill and
yewentao256
as code owners
October 7, 2026 02:38
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
TheEpicDolphin
added
the
ready
Member
Author
|
/ci run |
|
✅ Triggered Buildkite CI #93235 for commit |
Contributor
CI selector (shadow): 42 test steps (67 jobs) instead of 78 (97 jobs)Shadow mode: this changes nothing about what CI runs. It shows what the evidence-based selector would pick for this PR, next to today's rules. How it works. Feedback welcome: reply here if it would skip a step this change needs, or runs something unrelated.
Selector would run (42)
Would skip (today's rules run them) (54)
Would add (today's rules do not run them) (18)
AMD mirrors: would skip (50)
AMD mirrors: would add (9)
20 changed files · base |
stecasta
added a commit
to stecasta/vllm
that referenced
this pull request
Oct 7, 2026
Resolves the conflict with vllm-project#60335 (spec_decode/autoregressive renamed to target_dependent_ar): keeps main's imports and adds DraftConfidenceStop. Signed-off-by: Stefano Castagnetta <scastagnetta@nvidia.com>
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutoRegressiveSpeculatoris the base class for EAGLE, MTP, and Gemma4. WhenPlainDraftModelSpeculatorwas added in #43091 to support vanilla draft-model speculation, the base-class name became misleading: both are autoregressive.This PR renames them to make the actual distinction explicit:
AutoRegressiveSpeculatorwas renamed toTargetDependentARSpeculator.needs nothing from the target beyond the accepted/bonus token ids. This,
PlainDraftModelSpeculatorwas renamed toStandaloneARSpeculator.