Repository navigation
[CI] Require transformers 5.19 for the EmbeddingGemma2 registry test - #60295
Merged
khluu merged 2 commits intoOct 6, 2026
Merged
Conversation
transformers.models.embedding_gemma2 first ships in transformers 5.19.0, but the test registry entry added in vllm-project#60254 set min_transformers_version to 5.18.0. CI pins transformers==5.18.0, so test_registry_imports does not skip and fails with ModuleNotFoundError, turning Basic Models (Other) red on NVIDIA and AMD in every main build since. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: khluu <khluu000@gmail.com>
khluu
requested review from
AndreasKaratzas,
DarkLight1337 and
ywang96
as code owners
October 6, 2026 20:02
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
AndreasKaratzas
approved these changes
Oct 6, 2026
Member
|
/ci run |
|
✅ Triggered Buildkite CI #93186 for commit |
6 tasks
Merged
6 tasks done
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fix
models/test_registry.py::test_registry_imports[EmbeddingGemma2Model], which has failed on main since #60254. The test registry entry now requires transformers 5.19.0, the first release that hastransformers.models.embedding_gemma2.Claims
Validation
Ran in the CI image for main
bb87d227(includes #60254,transformers==5.18.0):pytest "models/test_registry.py::test_registry_imports[EmbeddingGemma2Model]"1 failed:ModuleNotFoundError: No module named 'transformers.models.embedding_gemma2'1 skipped: "transformers==5.18.0installed, buttransformers>=5.19.0is required to run this model."pytest models/test_registry.pywith the change: 392 passed, 17 skipped, 0 failed.Details
vllm/model_executor/models/embedding_gemma2.pyimportstransformers.models.embedding_gemma2at module level. That module is in transformers v5.19.0, released 2026-10-06, but not in v5.18.0. vLLM requirestransformers >= 5.16.1, < 5.19.0and CI pins 5.18.0. The registry entry saidmin_transformers_version="5.18.0", socheck_transformers_version(on_fail="skip")passed,ModelRegistry._try_load_model_clscaught the import error and returnedNone, and the test failed onassert model_cls is not None.The test will start running again once CI moves to transformers 5.19. The open follow-up #60289 doesn't touch
tests/models/registry.py, so the two don't overlap. cc @lucianommartins (author of #60254)This isn't a duplicate: I searched open PRs for
EmbeddingGemma2andtest_registry_importsand found only #60289.Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.
Claude Code wrote this change and ran the validation above. @khluu has not reviewed it yet; per AGENTS.md, he needs to review every line before it merges.
🤖 Generated with Claude Code