Repository navigation
[CI] Fix test_mixed_warmup_gate after #57053 - #60116
robertgshaw2-redhat merged 2 commits into
Conversation
vllm-project#57053 made the warmup read model_runner.num_speculative_steps; the fake runner in test_mixed_warmup_disables_watermarking, added by vllm-project#56801 just before, lacks it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
|
/ci run |
|
❌ This PR is 1 commit behind upstream |
|
/ci run |
|
✅ Triggered Buildkite CI #92951 for commit |
CI selector (shadow): 1 test steps (1 jobs) instead of 7 (10 jobs)Shadow mode: this changes nothing about what CI runs. It shows what the evidence-based selector would pick for this PR, next to today's rules. How it works. Feedback welcome: reply here if it would skip a step this change needs, or runs something unrelated.
Selector would run (1)
Would skip (today's rules run them) (6)
Would add (today's rules do not run them) (0)none AMD mirrors: would skip (4)
AMD mirrors: would add (0)none 1 changed files · base |
Purpose
tests/v1/worker/test_mixed_warmup_gate.py::test_mixed_warmup_disables_watermarkingfails on main, breaking the "V1 Executor + Worker" step (H200 MIG 18GB and MI355 DPX) for every PR:#56801 added this test with a fake runner; #57053, merged 17 minutes later, made the warmup read
model_runner.num_speculative_steps. Main build 92930 (#56801) passes the test; 92932 (#57053) fails it on both platforms.Fix: give the fake runner
num_speculative_steps=0.Test Plan
Test Result
On main (
74c5cbcd7b): 1 failed, 4 passed. With this PR: 5 passed (macOS, CPU).🤖 Generated with Claude Code