Skip to content

[CI] Fix test_mixed_warmup_gate after #57053 - #60116

Merged
robertgshaw2-redhat merged 2 commits into
vllm-project:mainfrom
MatthewBonanni:fix-mixed-warmup-gate-test
Oct 5, 2026
Merged

robertgshaw2-redhat merged 2 commits into
vllm-project:mainfrom
MatthewBonanni:fix-mixed-warmup-gate-test

Conversation

@MatthewBonanni

Copy link
Copy Markdown
Member

Purpose

tests/v1/worker/test_mixed_warmup_gate.py::test_mixed_warmup_disables_watermarking fails on main, breaking the "V1 Executor + Worker" step (H200 MIG 18GB and MI355 DPX) for every PR:

vllm/v1/worker/gpu/warmup.py:150: AttributeError: 'types.SimpleNamespace' object has no attribute 'num_speculative_steps'

#56801 added this test with a fake runner; #57053, merged 17 minutes later, made the warmup read model_runner.num_speculative_steps. Main build 92930 (#56801) passes the test; 92932 (#57053) fails it on both platforms.

Fix: give the fake runner num_speculative_steps=0.

Test Plan

pytest tests/v1/worker/test_mixed_warmup_gate.py

Test Result

On main (74c5cbcd7b): 1 failed, 4 passed. With this PR: 5 passed (macOS, CPU).

🤖 Generated with Claude Code

vllm-project#57053 made the warmup read model_runner.num_speculative_steps; the fake
runner in test_mixed_warmup_disables_watermarking, added by vllm-project#56801 just
before, lacks it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@MatthewBonanni MatthewBonanni added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 5, 2026
@MatthewBonanni

Copy link
Copy Markdown
Member Author

/ci run

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown

❌ This PR is 1 commit behind upstream main. Your branch must contain every commit currently on upstream main. No new CI build was started. Merge or rebase onto the latest main, then rerun /ci run. To test this branch at your own risk, use /ci run --allow-stale.

@MatthewBonanni

Copy link
Copy Markdown
Member Author

/ci run

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown

✅ Triggered Buildkite CI #92951 for commit f9834e30f567.

@robertgshaw2-redhat
robertgshaw2-redhat enabled auto-merge (squash) October 5, 2026 20:44
@vllm-agent

Copy link
Copy Markdown
Contributor

CI selector (shadow): 1 test steps (1 jobs) instead of 7 (10 jobs)

Shadow mode: this changes nothing about what CI runs. It shows what the evidence-based selector would pick for this PR, next to today's rules. How it works.

Feedback welcome: reply here if it would skip a step this change needs, or runs something unrelated.

steps (jobs) Today's rules Selector Would skip Would add
NVIDIA, CPU and others 7 (10) 1 (1) 6 (9) 0 (0)
AMD mirrors 5 (8) 1 (1) 4 (7) 0 (0)
Selector would run (1)
  • v1-executor-worker
Would skip (today's rules run them) (6)
  • cpu-spec-decode-tests
  • v1-core
  • v1-kv-connectors ×4
  • v1-kv-offload
  • v1-metrics-lmeval
  • v1-others-cpu
Would add (today's rules do not run them) (0)

none

AMD mirrors: would skip (4)
  • v1-core
  • v1-kv-connectors ×4
  • v1-kv-offload
  • v1-metrics-lmeval
AMD mirrors: would add (0)

none

1 changed files · base 18c8a65edd · head f9834e30f5 · Python record: build 92838 at 92044241a0 · kernel record: table 9204424 (build 92838), map 9204424 · not counted: 10 build steps, 5 A100 steps the generator no longer emits, 7 optional steps the selector would also run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants