Repository navigation
[CI] Bump peft to satisfy transformers 5.18 minimum - #59932
Merged
Merged
Conversation
transformers 5.18.0 raised MIN_PEFT_VERSION to 0.20.0, so granite-speech HF reference runs fail with the pinned peft 0.19.1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Member
Author
|
/ci run |
|
✅ Triggered Buildkite CI #92789 for commit |
DarkLight1337
approved these changes
Oct 4, 2026
DarkLight1337
enabled auto-merge (squash)
October 4, 2026 09:14
github-actions
Bot
added
the
ready
Collaborator
CI selector (shadow): 189 test steps (265 jobs) instead of 193 (269 jobs)Shadow mode: this changes nothing about what CI runs. It shows what the evidence-based selector would pick for this PR, next to today's rules. How it works. Feedback welcome: reply here if it would skip a step this change needs, or runs something unrelated.
Today's rules run everything for this diff. Selector would run (189)
Would skip (today's rules run them) (4)
Would add (today's rules do not run them) (0)none AMD mirrors: would skip (0)none AMD mirrors: would add (0)none 5 changed files · base |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
#59621 bumped the pinned transformers to 5.18.0, which raised
MIN_PEFT_VERSIONfrom 0.19.1 to 0.20.0, but leftpeft==0.19.1pinned in the test lockfiles. The granite-speech HF reference path now fails with:Claims
peftfloor inrequirements/test/{cuda,rocm}.into>=0.20.0.requirements/test/{cuda,rocm,cpu}.txt; the only change in each ispeft==0.19.1->peft==0.21.1.Validation
Lockfiles regenerated with the repo's pre-commit hooks:
The granite-speech and phi-4-mm tests have not been run locally; relying on CI for those.
Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.
🤖 Generated with Claude Code