Repository navigation
Conversation
Signed-off-by: Alexandre Milesi <milesial@users.noreply.github.com> Signed-off-by: milesial <milesial@users.noreply.github.com>
Signed-off-by: Alexandre Milesi <milesial@users.noreply.github.com> Signed-off-by: milesial <milesial@users.noreply.github.com>
milesial
marked this pull request as ready for review
October 2, 2026 21:19
milesial
requested review from
ProExpertProg,
WoosukKwon,
houseroad,
mgoin,
robertgshaw2-redhat,
tlrmchlsmth,
yewentao256 and
youkaichao
as code owners
October 2, 2026 21:19
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Reject Triton Mamba stochastic rounding with speculative decoding at startup. The speculative kernel silently ignores the rounding flag, including on supported Blackwell GPUs.
Claims
The shared
VllmConfigvalidation raises an actionable error for this combination. The error suggests--mamba-backend flashinferor disabling stochastic rounding.FlashInfer with rounding, Triton without rounding, and Triton rounding without speculation remain valid.
Validation
The four configuration cases pass. With the base implementation, the rejection case fails because startup accepts the combination. The other three cases pass.
The local run uses macOS ARM64 and PyTorch 2.13.0. The test mocks CUDA capability queries and calls the real
VllmConfigconstructor.--noconftestskips unrelated global fixtures. All applicable repository hooks pass.No new model evaluation is needed for this startup rejection. Accepted configurations retain their existing inference behavior.
Details
The Triton speculative branch saves FP16 state with a plain cast. Stochastic conversion only runs in the non-speculative branch. This omission dates to #35753 and affects real and synthetic acceptance.
The guard applies to every speculative method. Existing validation already requires an explicit FP16 state cache when stochastic rounding is enabled.
The PR changes only startup validation and its regression test. It makes no kernel, performance, or model-quality claims. The existing Engine Core CI job includes
tests/test_config.py.Duplicate searches covered
35753 in:body,Mamba stochastic rounding, andspeculative stochastic rounding Triton. #59729 changes FlashInfer seed scheduling. #40012 adds quantized state formats. Neither adds this startup rejection.AI assistance was used for the implementation, tests, and description.
Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.