Repository navigation
[Core][KV Connector] Keep the connector's head order when its KV layout is unsupported #59594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lucifer1004
wants to merge
1
commit into
vllm-project:main
Choose a base branch
from
lucifer1004:kv-layout-connector-fallback
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it be
self.value[_DIM_H] < self.value[_DIM_N]instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I believe
index()is right here. Each member's value lists the logical dims in physical order, so a dim's physical position isvalue.index(dim), notvalue[dim]. For example,BHLNC = (1, 2, 0, 3, 4)is physically[B, H, L, N, C]. The neighboring properties readvaluethe same way:is_block_outermostisvalue[0] == _DIM_B,is_block_contiguouscomparesvalue[-3:], andlayer_view_orderiterates overvalue.value[_DIM_H]is the logical dim stored at physical position 2. For the six layouts defined today, the two expressions happen to agree: five of the permutations are their own inverse, and BHLNC gives the same answer either way. They diverge for a layout likeLHNBC = (0, 2, 3, 1, 4), physically[L, H, N, B, C]. Each head's tokens are contiguous there, andvalue.index(2) = 1 < value.index(3) = 2says so, butvalue[2] = 3 > value[3] = 1would report it as not head-major. Happy to add a comment on the convention next to_DIM_*if that would help.