Skip to content

[TEST][XPU][CI] disable tests for nvidia ipc on xpu - #59578

Closed
microslaw wants to merge 4 commits into
vllm-project:mainfrom
microslaw:microslaw/skip-weight-sync-xpu-test
Closed

microslaw wants to merge 4 commits into
vllm-project:mainfrom
microslaw:microslaw/skip-weight-sync-xpu-test

Conversation

@microslaw

@microslaw microslaw commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Overview

vllm/tests/entrypoints/serve/dev/rlhf/test_weight_operation_metrics.py:test_weight_sync_metrics_aggregate_across_api_servers tests cuda-only feature on all platforms since #55781 ; This pr reduces scope of the that test to only cuda.

Claims

Skip tests for features that do not exist

Validation

python3 -m pytest -v -rs tests/entrypoints/serve/dev/rlhf/test_weight_operation_metrics.py
tee /results/wom/test_weight_operation_metrics.log
============================= test session starts ==============================
platform linux -- Python 3.12.3, pytest-9.1.1, pluggy-1.6.0 -- /opt/venv/bin/python3
cachedir: .pytest_cache
hypothesis profile 'default'
rootdir: /workspace/local
configfile: pyproject.toml
plugins: anyio-4.14.2, cov-7.1.0, timeout-2.4.0, hypothesis-6.165.10, rerunfailures-16.6, schemathesis-4.24.3, shard-0.1.2, asyncio-1.4.0, forked-1.7.5
asyncio: mode=Mode.STRICT, debug=False, asyncio_default_fixture_loop_scope=None, asyncio_default_test_loop_scope=function
collecting ... collected 1 item
Running 1 items in this shard: tests/entrypoints/serve/dev/rlhf/test_weight_operation_metrics.py::test_weight_sync_metrics_aggregate_across_api_servers

tests/entrypoints/serve/dev/rlhf/test_weight_operation_metrics.py::test_weight_sync_metrics_aggregate_across_api_servers SKIPPED [100%]

=============================== warnings summary ===============================
<frozen importlib._bootstrap>:488
  <frozen importlib._bootstrap>:488: DeprecationWarning: builtin type SwigPyPacked has no __module__ attribute

<frozen importlib._bootstrap>:488
  <frozen importlib._bootstrap>:488: DeprecationWarning: builtin type SwigPyObject has no __module__ attribute

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================== short test summary info ============================
SKIPPED [1] tests/entrypoints/serve/dev/rlhf/test_weight_operation_metrics.py:53: IPC weight transfer uses CUDA IPC.
======================== 1 skipped, 2 warnings in 2.40s ========================
sys:1: DeprecationWarning: builtin type swigvarlink has no __module__ attribute

Details

Similar to #59379, but this pr touches different tests


Pull Request Checklist
  • I used vLLM's /pr-checklist skill. (Mandatory for agents, optional for humans).

  • AI assistance was used during the creation of this PR.

  • Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.

  • Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.

  • Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.

  • Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.

Signed-off-by: Milosz Grunwald <milosz.grunwald@intel.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@mergify mergify Bot added the intel-gpu Related to Intel GPU label Oct 1, 2026
@microslaw microslaw changed the title [TEST][XPU][CI] disable xpu tests for nonexistent input norm kernels [TEST][XPU][CI] disable xpu tests for nvidia ipc Oct 1, 2026
@microslaw microslaw changed the title [TEST][XPU][CI] disable xpu tests for nvidia ipc [TEST][XPU][CI] disable tests for nvidia ipc on xpu Oct 1, 2026
@mergify mergify Bot added the nvidia label Oct 1, 2026
Signed-off-by: Milosz Grunwald <milosz.grunwald@intel.com>
@microslaw
microslaw force-pushed the microslaw/skip-weight-sync-xpu-test branch from e6fde5a to b2af42a Compare October 1, 2026 09:38

@jbyczkow jbyczkow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@microslaw microslaw closed this Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

intel-gpu Related to Intel GPU nvidia

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants